-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JAKALA: Add Calendar display option to Views Block for Events #753
Conversation
YOR-11: Create Events Calendar Functional
Created multidev environment pr-753 for yalesites-platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I do wonder if the tags and categories are needed in this calendar view.
@dblanken @kara-franco This ticket can be reviewed and merged, as long you're ok with the current behavior for Multi-day events that I described in Slack. |
…-calendar-display
@kara-franco @dblanken-yale Are we still able to get this pull request included in the release? |
@kara-franco The first three accessibility issues should be resolved now. |
hello @nplowman! I'm just catching up after returning from leave, so apologies if this has been mentioned before or is intentional. I noticed something on the pop-up that appears after clicking "X more events" on multi-event days: the header repeats the day number. For example, as shown in the screenshot: "19 September 19, 2024". |
@kara-franco The mobile styling has been updated and ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great to me! 👍
🎉 This PR is included in version 1.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
JAKALA: Event Calendar Display Mode
Description of work
Functional testing steps:
Notes
Related Pull Requests
Known Issues to Address