Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAKALA: Add Calendar display option to Views Block for Events #753

Merged
merged 18 commits into from
Oct 1, 2024

Conversation

nplowman
Copy link
Contributor

@nplowman nplowman commented Sep 11, 2024

JAKALA: Event Calendar Display Mode

Description of work

  • Adds a new "Calendar" display mode to the Views block for Events.

Functional testing steps:

  • Create several Event nodes for testing the View.
  • Make sure that at least some of the events include Categories and Tags.
  • For testing the modal functionality: Make sure that at least two of the events occur on the same date.
  • For testing pager functionality: Make sure there is at least one event is on a date in month other than the current month.
  • Create a Page node, and place a "View" block in the page layout.
  • In the View settings, make sure to select "Events" as the content type, and then select the new "Calendar" display option.

Notes

  • If there is more than a single event on a particular date, the first event will be shown on the calendar, and there will be a link that says "+1 more event". Clicking this will open a modal that shows all events on that date.
  • Categories and Tags can optionally be enabled for this view. Both will be shown in the modal view, but only tags will be shown in the calendar cell.

Related Pull Requests

Known Issues to Address

  • We still need to add conditional logic on the View Block edit form to hide fields that are not applicable to the calendar view, such as "Number of Items to Display".
  • There is an open discussion about the best way to display "multi-day events" on the calendar view.

@nplowman nplowman requested a review from a team as a code owner September 11, 2024 15:47
Copy link

Visit Site

Created multidev environment pr-753 for yalesites-platform.

Copy link

@atiddei atiddei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I do wonder if the tags and categories are needed in this calendar view.

@nplowman
Copy link
Contributor Author

@dblanken @kara-franco This ticket can be reviewed and merged, as long you're ok with the current behavior for Multi-day events that I described in Slack.

@nplowman
Copy link
Contributor Author

@kara-franco @dblanken-yale Are we still able to get this pull request included in the release?

@nplowman
Copy link
Contributor Author

FYI: Merge conflicts and code sniffer issues have been resolved.
We also pushed up a commit that improves the display of Multi-day events, to hopefully make it a little more clear when you are looking at a single event that spans multiple days vs multiple instances of an event with the same nname.

Screenshot 2024-09-17 at 9 16 02 AM

@kara-franco
Copy link

kara-franco commented Sep 17, 2024

Heya! I completed the accessibility review and have the following issues that need to be addressed:

  • Button text and aria-label need to match
Screenshot 2024-09-17 at 2 43 14 PM
  • Add day of the week sr-only<span>
Screenshot 2024-09-17 at 2 44 43 PM
  • Aria label should say close dialog instead of close modal
Screenshot 2024-09-17 at 2 45 19 PM
  • Mobile: display as list (if not, we need to implement a tab pattern). In current state it is a lot of tapping and guess work to find events.
Screenshot 2024-09-17 at 2 45 43 PM

@nplowman
Copy link
Contributor Author

nplowman commented Sep 20, 2024

@kara-franco The first three accessibility issues should be resolved now.
Updates to the mobile design should be coming next week.

@miketullo95
Copy link
Contributor

hello @nplowman! I'm just catching up after returning from leave, so apologies if this has been mentioned before or is intentional. I noticed something on the pop-up that appears after clicking "X more events" on multi-event days: the header repeats the day number. For example, as shown in the screenshot: "19 September 19, 2024".

Screenshot 2024-09-24 at 1 25 37 PM

@nplowman
Copy link
Contributor Author

@kara-franco The mobile styling has been updated and ready for review.
@miketullo95 The duplicate day issue is also fixed now.

Copy link
Contributor

@miketullo95 miketullo95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great to me! 👍

@dblanken-yale dblanken-yale removed their request for review October 1, 2024 14:52
@dblanken-yale dblanken-yale self-assigned this Oct 1, 2024
@dblanken-yale dblanken-yale merged commit 4916954 into develop Oct 1, 2024
3 checks passed
@yalesites yalesites mentioned this pull request Oct 2, 2024
@yalesites
Copy link

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants