Release v1.9.0 #776
Merged
Release v1.9.0 #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YOR-11: Create Events Calendar Functional
…-calendar-display
Fix linting issues on develop preventing multidev creation
It looks as if there is a deprecation warning on first load regarding the placement of $cachable and $entity on the ys_themes_allowed_values_function in ys_themes. I am attempting to switch the order of the variables to squelch this deprecation warning on first load for sites. The deprecation warning: Deprecated: Optional parameter $entity declared before required parameter $cacheable is implicitly treated as a required parameter in /code/web/profiles/custom/yalesites_profile/modules/custom/ys_themes/ys_themes.module on line 28
This reverts commit d44d33b.
We had a $cachable which was not even in the signature of options_allowed_values, yet we were passing something in that then wasn't even being used. This lets it match the signature found at: https://api.drupal.org/api/drupal/core%21modules%21options%21options.module/function/options_allowed_values/10
…lues-deprecation YSP-690: Deprecation of parameters with default values order
Marc has written about this, and it looks as if when an item is no longer present in the payload that it gets wiped, which we do not want. So we removed this; more testing needs to be done on the effects of changing the data and how it updates.
YSP-593: ServiceNow Knowledge Base Syncing
…dial YSP-680: PRESIDENT: Add dial to image banner to allow default and large image display
YSP-346: Add pronoun field
JAKALA: Add Calendar display option to Views Block for Events
This increases the maximum character limit on spotlights from 500 to 650 characters.
…it-increase YSP-693: Increase hard limit on spotlights to 650 characters
…-point YSP-697: Image Banner not respecting focal point
Apply new atomic version with image banner fix Revert "YSP-697: Image Banner not respecting focal point"
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requests
Changes without a pull request: