YSP-593: ServiceNow Knowledge Base Syncing #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created multidev environment pr-737 for yalesites-platform. |
dblanken-yale
force-pushed
the
YSP-593-service-now-feed
branch
from
131418e to
369c84c
Compare
dblanken-yale
force-pushed
the
YSP-593-service-now-feed
branch
from
e373336 to
d1dd332
Compare
atiddei
approved these changes
Sep 12, 2024
dblanken-yale
force-pushed
the
YSP-593-service-now-feed
branch
2 times, most recently
from
58f2814 to
1079141
Compare
dblanken-yale
force-pushed
the
YSP-593-service-now-feed
branch
from
178400a to
9d19e7c
Compare
dblanken-yale
added
pass functional review
pass a11y review
and removed
pass a11y review
labels
In case we need to use this in the future, we now have a way to do this without specifying servicenow specifically.
A byproduct of setting syncSource is that the layout builder items need to be recreated. This is a benefit to us I believe in that we don't need to figure out if it needs updating, we just add a new block with the new content. My only worry is that database data is not being deleted when this happens; I need to look more into this.
Remove the endpoint since it's hardcoded into the YAML.
It seems when migrations happen, they skip the callbacks that items would normally have. In our case, it's not triggering our ai module hook to update. This is an attempt to save them so that it can pick it up.
Marc has written about this, and it looks as if when an item is no longer present in the payload that it gets wiped, which we do not want. So we removed this; more testing needs to be done on the effects of changing the data and how it updates.
dblanken-yale
force-pushed
the
YSP-593-service-now-feed
branch
from
5d4dcc4 to
958e94f
Compare
Merged
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YSP-593: ServiceNow Knowledge Base Syncing
Description of work
ys_servicenowfor user 1 to sync from an endpointkeysmodule based authentication for migrationsys_servicenowto config ignore and enables the module turned off by defaultworkflow_statepassed via endpoint (Not tested yet as there are none to toggle)Functional testing steps:
Todo