-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add preCreateIdentityCallback & preEnableIdentityCallback #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to see the callbacks running locally by testing against your linked android and ios PRs. Everything worked well. This PR looks good to me.
I think we should wait for the Android and iOS PRs to merged before we merge this one so that we can update the native modules in this PR for xmtp-react-native to run properly.
As soon as those PRs are approved and merged, I think we can merge this one as well. Nice work @kele-leanes !
… feat/pre-callback-events
I'm getting an error when I try to run the app after pulling in main and bumping the versions.
It might be related to @alexrisch hook changes? |
I was able to revert the hooks PR and validate the example was working prior to that. I'm going to merge this to unblock integrators and we can fix the example app in a follow up as I confirmed the SDK works as intended only the example is broken. |
🎉 This PR is included in version 1.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Created a PR which should hopefully fix these weird resolutions and the hook PR: #185 TLDR: Resolutions are a pain, and multiple react versions were being used |
Description:
This pull request introduces the implementation of
preCreateIdentityCallback
andpreEnableIdentityCallback
functionalities, addressing the specific requirements outlined in this ticket. The implementation leverages event handling, as it is the most suitable approach for executing JavaScript code from the native side.To achieve this, the code ensures proper execution of the specified callbacks, and subsequently, an unsubscription process is initiated. This unsubscription is crucial to prevent inadvertent re-execution of the callback every time the Client is created.
Thorough testing has been conducted with this Android package version and this iOS package