fix: sign actions should wait for preCallback completion before proceeding

[cameronvoell]

Related PRs:

• feat: add preCreateIdentityCallback & preEnableIdentityCallback #177
• fix: callbacks in auth flow no longer unsubscribed too early #192
• feat: add PreEventCallback xmtp-android#144
• feat: add PreEventCallback xmtp-ios#201

Description

• TypeScript code updated
• Android Kotlin code updated
• iOS Swift code updated
• Finish verifying no unexpected error conditions can occur (see To Test section below)

In the PRs linked above we added a callback that could be passed in during identity creation that would be fired to notify when identity creation and enabling occurred.

However those callbacks were implemented in a way that merely notified that sign actions would occur without actually blocking the signing actions until the callbacks were finished.

For example, the preEventCallbacks in xmtp-js block signing actions until after callbacks are finished, which gives developers greater flexibility: https://github.com/xmtp/xmtp-js/blob/e96b2e214bef3965f703be09863fa8b2fb4552d2/src/Client.ts#L178-L194

This change updates our code to wait until callbacks are completed before resuming identity sign request logic.

To Test

The following branch has changes from this PR cherry-picked on to a branch that has in progress code for connecting external wallets in the example app (via thirdweb-sdk + wallet connect): cameronvoell-callback-testing-wallet

Paths to check:

1. Passing in callbacks blocks signing actions until callback completes on Android + iOS
2. Identity creation works as expected when no callbacks are passed in to identity creation functions on Android and iOS
3. Paths where errors occur due to rejected signing attempts or anything else do not cause callbacks to block identity creation indefinitely or lead to any other unexpected errors.

[github-actions]

🎉 This PR is included in version 1.23.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀