Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: add subst. in I2S doc, move decl. in tests #101

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

ACascarino
Copy link
Contributor

From review on #100

@ACascarino ACascarino added type: cleanup no functional ot performance impact size:S small labels Feb 9, 2024
@ACascarino ACascarino requested a review from xhuw February 9, 2024 15:07
@ACascarino ACascarino requested a review from mbanth February 9, 2024 15:08
@mbanth mbanth assigned ACascarino and unassigned mbanth Feb 9, 2024
Copy link
Collaborator

@mbanth mbanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One documentation fix.

@@ -7,9 +7,9 @@
===============

The macro I2S_DATA_WIDTH may be set as a compile flag (e.g.
-DI2S_DATA_WIDTH=16) to alter the number of bits per word for both the I2S
-DI2S_DATA_WIDTH=16) to alter the number of bits per word for both the |I2S|
Master and I2S Slave components; this defaults to 32 bits per word. This
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more I2S that needs changed to |I2S|.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, done!

@ACascarino ACascarino requested a review from mbanth February 9, 2024 15:24
@ACascarino ACascarino merged commit 0ecba51 into xmos:develop Feb 9, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S small type: cleanup no functional ot performance impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants