Prepare release v3.5.0 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(They currently fail)
Add support for non-32b data widths in I2S
mbanth
approved these changes
Feb 9, 2024
| @@ -6,6 +6,12 @@ | |||
| |I2S| Instances | |||
| =============== | |||
|
|
|||
| The macro I2S_DATA_WIDTH may be set as a compile flag (e.g. | |||
| -DI2S_DATA_WIDTH=16) to alter the number of bits per word for both the I2S | |||
There was a problem hiding this comment.
Please change I2S to |I2S| at the end of this line and in lines 11 and 12.
test/lib_i2s/i2s_slave_checker.py
Outdated
| ) | ||
| clock_half_period = float(1000000000000) / float(2 * bclk_frequency) | ||
| clock_half_period = float(ONE_SECOND_FS) / float(2 * bclk_frequency) | ||
| data_bit_mask = int("1" * data_bits, base=2) |
There was a problem hiding this comment.
Moving the definition of data_bit_mask closer to its first use might improve maintainability slightly. The first use is over 100 lines away.
hotfix: add subst. in I2S doc, move decl. in tests
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entirety of release is just that which was merged in #99
I2S tests fail. This is known as a major issue with the test runner. Can confirm that the tests pass when manually run.