KANSUP74-23: introduce additional pvcs activemq

[pvriel]

Started from https://xenitsupport.jira.com/browse/KANSUP74-23

Kansspelcommissie uses an NFS mount for both the ACS, Solr & ActiveMQ data.
For ACS, the problem was previously addressed by disabling the persistent storage of the ACS pods & adding a replacement volume & mount for a PV(C) pointing to the NFS mount. However, this option does not seem to be possible for ActiveMQ with the current version of our Helm charts.

This PR:

• introduces the mq.additionalVolumes option;
• introduces the mq.additionalVolumeMounts option;
• introduces the persistentStorage.mq.additionalClaims option.

An alternative solution would have been to introduce NFS support in the volume helper. However, most templates for Kansspelcommissie have already been written, so investing time in this alternative approach seems to be wasteful at the moment.

[gert-glassee]

you should set the volumeMounts: and volumes: entry outside of the check otherwise you cannot disable persistentstorage and use the alternative manualy created volumemount.

` volumeMounts:
{{- if .Values.persistentStorage.mq.enabled }}
              - name: data`

[gert-glassee]

If you also want to enable addittionalClaims (to be managed by the helm helper) you should also alter the mq-volumes.yaml (see alfresco-volumes.yaml)
{{- if .additionalClaims }} {{- range .additionalClaims }} {{- $name := .name -}} {{- $storageClassName := .storageClassName -}} {{- $storage := .storage -}} {{- $efsVolumeHandle := .efs.volumeHandle -}} {{- include "hepers.volumeHelper" (list $namespace $name $storageClassName $storage $efsVolumeHandle) }}

[pvriel]

@gert-glassee I'm confused; I thought that is already the case:

{{- if .Values.persistentStorage.mq.enabled }}
volumeMounts:
- name: data
mountPath: /opt/activemq/data
subPath: mq/data
{{- end }}
{{- if .Values.persistentStorage.mq.additionalClaims }}
{{- range .Values.persistentStorage.mq.additionalClaims }}
- name: {{ .name }}
mountPath: {{ .mountPath }}
subPath: {{ .subPath }}
{{- end }}
{{- end }}

I thought the first 'end'-statement ended the if-statment.

Same here:

{{- if .Values.persistentStorage.mq.enabled }}
volumes:
- name: data
persistentVolumeClaim:
claimName: mq-pvc
{{- end }}
{{- if .Values.persistentStorage.mq.additionalClaims }}
{{- range .Values.persistentStorage.mq.additionalClaims }}
- name: {{ .name }}
persistentVolumeClaim:
claimName: {{ .name }}-pvc
{{- end }}
{{- end }}
{{- if .Values.mq.additionalVolumes }}
{{- toYaml .Values.mq.additionalVolumes | nindent 8 }}
{{- end }}

[pvriel]

Ignore my previous comments; I was wrong. The necessary changes have been applied.