Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple folders in class_package node registration key #123

Merged
merged 15 commits into from
Mar 4, 2024

Conversation

parul-l
Copy link
Collaborator

@parul-l parul-l commented Mar 4, 2024

Description

In this PR we allow the class_package key in the metadata portion of the primrose config to be a list of folders to search for potential node candidates. For example, given the folder structure

├── config
│   ├── my_primrose_config.yml
├── src
│   ├── readers
│   │   ├── reader_node.py
│   ├── pipelines
│   │   ├── pipeline_node.py
├── sample_project
│   ├── sample_project_node.py

we can specify the potential node candidate folders in the metadata as:

metadata:
  class_package:
    - './src'
    - './sample_project'

implementation_config:
  reader_config:
  ...

This allows our DAG to use nodes from both the src and sample_project folders.

Types of change

Enhancement

Checklist

  • I squashed my commits to a reasonable number of descriptive commits.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

briangrahamww
briangrahamww previously approved these changes Mar 4, 2024
Copy link
Collaborator

@briangrahamww briangrahamww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to patch something for an existing project or for new dev?

@parul-l
Copy link
Collaborator Author

parul-l commented Mar 4, 2024

Is this to patch something for an existing project or for new dev?

New development.

Copy link
Collaborator

@briangrahamww briangrahamww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since we need to resolve this issue to move forward with internal projects. We will keep the changes in master and not do a release until the pygraphviz error is resolved.

@parul-l parul-l merged commit 328076b into master Mar 4, 2024
10 of 11 checks passed
parul-l added a commit that referenced this pull request Mar 19, 2024
parul-l added a commit that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants