Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Allow multiple folders in class_package node registration key" #124

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Revert "Allow multiple folders in class_package node registration key" #124

merged 1 commit into from
Mar 19, 2024

Conversation

parul-l
Copy link
Collaborator

@parul-l parul-l commented Mar 19, 2024

Reverts #123

Reverting this change because it breaks instantiation of the primrose.configuration.configuration.Configuration object when the is_dict_config param is set to True.

@parul-l
Copy link
Collaborator Author

parul-l commented Mar 19, 2024

Merging. Failed tests are known and will be addressed in another PR.

@parul-l parul-l merged commit 9d2952b into master Mar 19, 2024
1 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangrahamww briangrahamww briangrahamww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parul-l @briangrahamww