-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial groundwork for generating test mode Stripe Connect URLs #3320
Merged
james-allan
merged 17 commits into
develop
from
issue/3291-add-support-for-connecting-in-test-mode
Aug 2, 2024
Merged
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
20848e5
Add support for sending test mode requests to api.woocommerce.com
james-allan f83a3cb
Update the account connection UI to support test and live account con…
james-allan 8e767ab
Translate connect button text and make it consistent with other conne…
james-allan 8b57fa9
Remove legacy oauth function
diegocurbelo a1d6840
Update Woo Connect Server enpoints for test/sandbox mode
diegocurbelo 7834920
Add Connect a test account button to onboarding page
diegocurbelo d052128
Update JS tests for Connect account buttons
diegocurbelo 6acaf6d
Pass the account ID to the oauth init request if its connected to an …
james-allan b2bdc2b
Add tests for get_cached_account_data() with param
james-allan b3058f0
Fix unit tests
james-allan 6fbdaf7
Include check for is_null
james-allan c531b1a
Remove extra line added by mistake
james-allan cec0415
Add $mode param function doc block comments
james-allan a1c5c8d
When caching an account in a specific mode, ensure we set the correct…
james-allan 1fbeb08
Add unit tests for WC_Stripe_API
james-allan 11179b5
fix unit test
james-allan 92baae3
Merge branch 'develop' into issue/3291-add-support-for-connecting-in-…
james-allan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the previous PR these strings weren't translated (🙈) and in this PR I've also taken the opportunity to make the button text consistent with the text on the other connect UI.
Create or connect an account button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a button (secondary if there is a valid live url) to connect a test account:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I had been working on this test button over here: #3318
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my PR I've taken into consideration the notice and the case if only 1 of the URLs is returned. I think we can probably merge this PR once it's good and then my PR can just be updated to improve on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, nice work on #3318, those error notices over the buttons look awesome.