-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial groundwork for generating test mode Stripe Connect URLs #3320
Initial groundwork for generating test mode Stripe Connect URLs #3320
Conversation
: __( | ||
'Create or connect an account', | ||
'woocommerce-gateway-stripe' | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I had been working on this test button over here: #3318
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my PR I've taken into consideration the notice and the case if only 1 of the URLs is returned. I think we can probably merge this PR once it's good and then my PR can just be updated to improve on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, nice work on #3318, those error notices over the buttons look awesome.
The sandbox endpoints have been deployed to the connect server, we can merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge this as there's an approving review and it's been a big PR that we've both worked on. There is an issue we will need to fix however. I cannot onboard to a live account. I suspect what is happening is we generate the oauth URL and store in a transient the |
That seems like the likely cause, I'll fix it while adding the Stripe App flow. |
Fixes #3291
Changes proposed in this Pull Request:
This PR updates the
WC_Stripe_Connect_API
class to add general support for generating test mode Stripe Connect URLs. It also updates the placeholder URL being used for the Connect a test account button on the Configure connection modal - it was previously using the live URL.Testing instructions
npm run build
changelog.txt
andreadme.txt
(or does not apply)Post merge