Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle snaktype: «somevalue». #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

Handle snaktype: «somevalue». #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/wikidata/snak.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ def property

def value
@value ||= begin
if datavalue['type'] == "wikibase-entityid"
if snaktype == "somevalue"
Wikidata::DataValues::String.new({string: "Unknown"})
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be its own Value subclass since it represents something specific that isn't really a string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, will be smarter.

elsif datavalue['type'] == "wikibase-entityid"
Wikidata::DataValues::Entity.new(datavalue.value)
elsif datavalue['type'] == "time"
Wikidata::DataValues::Time.new(datavalue.value)
Expand Down