Handle snaktype: «somevalue». #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From http://www.wikidata.org/wiki/Wikidata:Glossary/en#Property « Unknown value is a marker for when there is some value but the exact value is not known for the property. "Some value" means that there is nothing known for the value except that it should exist and not imply a negation of the claim (example: if the date of a human's death is completely unknown the item would receive this marker for date of death (P570), denoting that the human is, in fact, dead — however, with the date of death being unknown). »
| @@ -11,7 +11,9 @@ def property | |||
|
|
|||
| def value | |||
| @value ||= begin | |||
| if datavalue['type'] == "wikibase-entityid" | |||
| if snaktype == "somevalue" | |||
| Wikidata::DataValues::String.new({string: "Unknown"}) | |||
There was a problem hiding this comment.
Perhaps this should be its own Value subclass since it represents something specific that isn't really a string?
There was a problem hiding this comment.
Yep, will be smarter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From http://www.wikidata.org/wiki/Wikidata:Glossary/en#Property
« Unknown value is a marker for when there is some value but the exact
value is not known for the property. "Some value" means that there is
nothing known for the value except that it should exist and not imply a
negation of the claim (example: if the date of a human's death is
completely unknown the item would receive this marker for date of death
(P570), denoting that the human is, in fact, dead — however, with the
date of death being unknown). »