Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YiR] Learn more web view #5052

Merged
merged 18 commits into from
Nov 7, 2024
Merged

[YiR] Learn more web view #5052

merged 18 commits into from
Nov 7, 2024

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T378839

Notes

This PR allows for a "Donate" button overlay to be displayed on top of SinglePageWebViewController, similar to how we display the "Return" button on the thank you web view.

I refactored SinglePageWebViewController a bit to allow the passing in of a configType enum, along with associated config data. I'm not sure if this clears it up much but I was getting a bit mixed up in that file without the cleanup.

I also added a developer settings toggle for "Bypass donation". This causes a "fake success" in both the native and web donate flows, so that we can test successful donation navigation without having to make an actual donation.

This PR depends on the work in #5048. Please merge that PR first.

Test Steps

Note: This can be tested more easily once the donate slide UI work is in.

  1. Ensure simulator region and primary app language lines up with YiR target countries / languages. Log into account with edits.
  2. Go to developer settings menu, toggle both YiR feature flag and "Bypass donation". Background, foreground the app. YiR entry point should appear.
  3. Temporarily add test code from ac59c77,.
  4. Go through YiR flow. On last slide, tap "Done". The temp code mimics how this will act once the "learn more" button is tapped on the Donate slide.
  5. Ensure web view appears with "Donate" button on top. Tap Donate button. Ensure donate flow appears.
  6. Donate from one of the forms. You should be able to use fake wallet details in simulator now. Developer settings toggle should allow donation to suceeed.
  7. Ensure you are popped back to learn more web view after donation.

@tonisevener tonisevener added the Dependent PR PR is dependent on another PR - merge dependent PR first and update branch before merging label Nov 5, 2024
@tonisevener tonisevener requested review from a team and mazevedofs and removed request for a team November 5, 2024 17:11
Base automatically changed from yir-donate-present to main November 5, 2024 20:35
@tonisevener tonisevener removed the Dependent PR PR is dependent on another PR - merge dependent PR first and update branch before merging label Nov 6, 2024
@@ -98,6 +98,7 @@
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
disablePerformanceAntipatternChecker = "YES"
language = "en"
region = "MX"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weirdly I don't see it locally on Xcode

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed now!

Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just needs fixing conflicts! I'm not sure why the region on the schema persisted as MX, but locally I don't see it

@tonisevener tonisevener merged commit eb1d4db into main Nov 7, 2024
4 checks passed
@tonisevener tonisevener deleted the yir-learn-more-web-view branch November 7, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants