-
-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YiR] Learn more web view #5052
Conversation
@@ -98,6 +98,7 @@ | |||
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB" | |||
disablePerformanceAntipatternChecker = "YES" | |||
language = "en" | |||
region = "MX" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weirdly I don't see it locally on Xcode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just needs fixing conflicts! I'm not sure why the region on the schema persisted as MX, but locally I don't see it
Phabricator: https://phabricator.wikimedia.org/T378839
Notes
This PR allows for a "Donate" button overlay to be displayed on top of SinglePageWebViewController, similar to how we display the "Return" button on the thank you web view.
I refactored SinglePageWebViewController a bit to allow the passing in of a
configType
enum, along with associated config data. I'm not sure if this clears it up much but I was getting a bit mixed up in that file without the cleanup.I also added a developer settings toggle for "Bypass donation". This causes a "fake success" in both the native and web donate flows, so that we can test successful donation navigation without having to make an actual donation.
This PR depends on the work in #5048. Please merge that PR first.
Test Steps
Note: This can be tested more easily once the donate slide UI work is in.