Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YiR] Add Donate slide UI #5054

Merged
merged 10 commits into from
Nov 7, 2024
Merged

[YiR] Add Donate slide UI #5054

merged 10 commits into from
Nov 7, 2024

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T378838

Notes

This PR completes the donate slide.

Note: This PR depends on #5052. Be sure that PR is merged first.

Test Steps

  1. Fresh install app, ensure you are in the correct device region and primary app language. Ensure you are logged into an account with edits on that primary app language.
  2. Go to developer settings. Enable bypass donation toggle. Go to Donate item in profile, make a donation via simulator.
  3. Go to developer settings, enable YiR feature toggle. Background and foreground app.
  4. Go through Year in Review. Confirm last slide looks correct (should be personalized slide, "Thank you for your contribution". Button should say "Finish" instead of "Next" and red donate button should be hidden.
  5. Tap "Learn more" link in text. In-app web view should present.
  6. Repeat steps 1-5, but skip step 2.
  7. Now collective donate slide should appear ("0 ads..."). Red donate button should remain. Button should still say "Finish" instead of "Next.
  8. Tap "Learn more" link in text. In-app web view should present, with a "Donate now" button overlay.

@tonisevener tonisevener added the Dependent PR PR is dependent on another PR - merge dependent PR first and update branch before merging label Nov 6, 2024
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Base automatically changed from yir-learn-more-web-view to main November 7, 2024 21:08
@tonisevener tonisevener removed the Dependent PR PR is dependent on another PR - merge dependent PR first and update branch before merging label Nov 7, 2024
@tonisevener
Copy link
Collaborator Author

There's some design review feedback on this one. I will fix it in a followup PR.

@tonisevener tonisevener merged commit c51e406 into main Nov 7, 2024
4 checks passed
@tonisevener tonisevener deleted the yir-donate-UI branch November 7, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants