Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch product variant pre and post update/create event in Import #183

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Dispatch product variant pre and post update/create event in Import #183

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be57b6f
Dispatch product variant pre and post update/create event in Import
LucaGallinari Oct 30, 2023
8fa0a06
Apply suggestions from code review
lruozzi9 Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions src/Product/Importer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,12 +160,15 @@ public function import(string $identifier): void
}
}

$eventName = $product->getId() ? 'update' : 'create';
$this->dispatchPreEvent($product, $eventName);
$productEventName = $product->getId() ? 'update' : 'create';
$productVariantEventName = $productVariant->getId() ? 'update' : 'create';
$this->dispatchPreEvent($productVariant, 'product_variant', $productVariantEventName);
$this->dispatchPreEvent($product, 'product', $productEventName);
// TODO We should handle $event->isStopped() where $event is the return value of the dispatchPreEvent method.
// See \Sylius\Bundle\ResourceBundle\Controller\ResourceController.
$this->productRepository->add($product);
$this->dispatchPostEvent($product, $eventName);
$this->dispatchPostEvent($productVariant, 'product_variant', $productVariantEventName);
$this->dispatchPostEvent($product, 'product', $productEventName);
}

/**
Expand Down Expand Up @@ -217,21 +220,21 @@ private function getOrCreateProductFromVariantResponse(array $productVariantResp
return $product;
}

private function dispatchPreEvent(ResourceInterface $product, string $eventName): ResourceControllerEvent
private function dispatchPreEvent(ResourceInterface $product, string $resourceName, string $eventName): ResourceControllerEvent
{
$event = new ResourceControllerEvent($product);
$event->setArgument(self::EVENT_AKENEO_IMPORT, true);
$this->eventDispatcher->dispatch($event, sprintf('sylius.product.pre_%s', $eventName));
$this->eventDispatcher->dispatch($event, sprintf('sylius.%s.pre_%s', $resourceName, $eventName));

return $event;
}

private function dispatchPostEvent(ResourceInterface $product, string $eventName): ResourceControllerEvent
private function dispatchPostEvent(ResourceInterface $product, string $resourceName, string $eventName): ResourceControllerEvent
{
$event = new ResourceControllerEvent($product);
$event->setArgument(self::EVENT_AKENEO_IMPORT, true);
/** @psalm-suppress InvalidArgument */
$this->eventDispatcher->dispatch($event, sprintf('sylius.product.post_%s', $eventName));
$this->eventDispatcher->dispatch($event, sprintf('sylius.%s.post_%s', $resourceName, $eventName));

return $event;
}
Expand Down Expand Up @@ -353,11 +356,13 @@ public function reconcile(array $identifiersToReconcileWith): void

$product->setEnabled(false);

$this->dispatchPreEvent($product, 'update');
$this->dispatchPreEvent($productVariantIdentifierToDisable, 'product_variant', 'update');
lruozzi9 marked this conversation as resolved.
Show resolved Hide resolved
$this->dispatchPreEvent($product, 'product', 'update');
// TODO We should handle $event->isStopped() where $event is the return value of the dispatchPreEvent method.
// See \Sylius\Bundle\ResourceBundle\Controller\ResourceController.
$this->productRepository->add($product);
$this->dispatchPostEvent($product, 'update');
$this->dispatchPostEvent($productVariantIdentifierToDisable, 'product_variant', 'update');
lruozzi9 marked this conversation as resolved.
Show resolved Hide resolved
$this->dispatchPostEvent($product, 'product', 'update');
}
}

Expand Down
Loading