Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch product variant pre and post update/create event in Import #183

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

LucaGallinari
Copy link
Member

Fixes #182

@webgriffe/wg-devs what do you think about this PR :shipit:?

@LucaGallinari LucaGallinari force-pushed the dispatch-product-variant-event branch from 1a57a05 to df2db7b Compare October 30, 2023 10:44
@LucaGallinari LucaGallinari force-pushed the dispatch-product-variant-event branch from df2db7b to be57b6f Compare October 30, 2023 11:05
@LucaGallinari LucaGallinari changed the base branch from master to 1.17 October 30, 2023 11:05
Copy link
Member

@lruozzi9 lruozzi9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @LucaGallinari, just a fix!

src/Product/Importer.php Outdated Show resolved Hide resolved
src/Product/Importer.php Outdated Show resolved Hide resolved
Copy link
Member

@lruozzi9 lruozzi9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@lruozzi9 lruozzi9 merged commit 203dcd6 into 1.17 Oct 30, 2023
0 of 24 checks passed
@lruozzi9 lruozzi9 deleted the dispatch-product-variant-event branch October 30, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dispatch pre/post create/update events for product variant
2 participants