-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce point cloud data to positional data #11
Open
soulofmischief
wants to merge
15
commits into
master
Choose a base branch
from
strip-point-cloud-data
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+47
−3
Open
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5e0bd20
Reduce point cloud data to positional data
soulofmischief fb7c7ef
Cache data view
soulofmischief 14a5f60
Use local variable instead of inner await
soulofmischief 1a81b82
rename getDestructuredPointCloud move to utils
soulofmischief a1e0919
Use memoized point cloud stride
soulofmischief 34ebdea
Lint code
soulofmischief 19c2a41
Reduce point cloud data to positional data
soulofmischief 8dfcebe
Cache data view
soulofmischief 5fd2a14
Use local variable instead of inner await
soulofmischief b755d06
rename getDestructuredPointCloud move to utils
soulofmischief 00cbdca
Use memoized point cloud stride
soulofmischief 04a7acb
Lint code
soulofmischief 5b14275
Merge branch 'strip-point-cloud-data' of github.com-soulofmischief:up…
soulofmischief 3995f5a
Bump zine
soulofmischief 6610583
Bump zine
soulofmischief File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
|
||
const pointcloudStride = 4 + 4 + 4 + 1 + 1 + 1; | ||
|
||
|
||
/** | ||
* Destructure a point cloud into its component parts. | ||
*/ | ||
export function getDestructuredPointCloud(arrayBuffer) { | ||
const numPoints = arrayBuffer.byteLength / pointcloudStride; | ||
const points = new Float32Array(numPoints * 3); | ||
const colors = new Uint8Array(numPoints * 3); | ||
const intensities = new Uint8Array(numPoints); | ||
const classifications = new Uint8Array(numPoints); | ||
|
||
let pointIndex = 0; | ||
let colorIndex = 0; | ||
let intensityIndex = 0; | ||
let classificationIndex = 0; | ||
|
||
for (let i = 0; i < arrayBuffer.byteLength; i += pointcloudStride) { | ||
points[pointIndex++] = new DataView(arrayBuffer).getFloat32(i, true); | ||
soulofmischief marked this conversation as resolved.
Show resolved
Hide resolved
|
||
points[pointIndex++] = new DataView(arrayBuffer).getFloat32(i + 4, true); | ||
points[pointIndex++] = new DataView(arrayBuffer).getFloat32(i + 8, true); | ||
|
||
colors[colorIndex++] = arrayBuffer[i + 12]; | ||
colors[colorIndex++] = arrayBuffer[i + 13]; | ||
colors[colorIndex++] = arrayBuffer[i + 14]; | ||
|
||
intensities[intensityIndex++] = arrayBuffer[i + 15]; | ||
classifications[classificationIndex++] = arrayBuffer[i + 16]; | ||
} | ||
|
||
return { | ||
points: points.buffer, | ||
colors: colors.buffer, | ||
intensities: intensities.buffer, | ||
classifications: classifications.buffer, | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
|
||
export { getDestructuredPointCloud } from './getDestructuredPointCloud.js'; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a good name for this... We already have a convention of calling these utils. It's certainly not an index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Convention noted, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything in particular come to mind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is pointCloudDestructureUtil good?