Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versioneer version to work with python 3.11 #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

davfsa
Copy link

@davfsa davfsa commented Nov 21, 2021

Summary

We have been trying to bump one of my projects to support 3.11 but ed25519 seemed to fail to install due to issues with versioneer. The issue has been fixed upstream in versioneer, so bumping it here too would be nice to allow to install once 3.11 comes out.

Additionally, I have also changed from Travis CI to Github Actions (which would have to be enabled in the settings for this repository) and added all the missing python versions as well as testing in all the different operating systems (ubuntu, windows and macOS). This was a bit of a personal preference change and I can revert it if needed, just thought it would be nice since Travis CI public now uses credits you need to apply for as an OSS as well as not allowing for concurrent runs without a paywall. Hopefully this change is welcome, but I can revert it if needed

Lastly, I cleaned up the .gitignore a bit to ignore some more common files to prevent any future contributors from mistakenly committing unrelated files

Build failure

Click to expand
Collecting ed25519==1.5
  Using cached ed25519-1.5.tar.gz (868 kB)
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'error'
  ERROR: Command errored out with exit status 1:
   command: 'D:\a\hikari\hikari\.nox\pytest-speedups\Scripts\python.EXE' -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pip-install-4aa3kr17\\ed25519_a0ba2e70de714928beb6110d8ba37a8a\\setup.py'"'"'; __file__='"'"'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pip-install-4aa3kr17\\ed25519_a0ba2e70de714928beb6110d8ba37a8a\\setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base 'C:\Users\runneradmin\AppData\Local\Temp\pip-pip-egg-info-p_9jj6l9'
       cwd: C:\Users\runneradmin\AppData\Local\Temp\pip-install-4aa3kr17\ed25519_a0ba2e70de714928beb6110d8ba37a8a\

  Complete output (15 lines):

  Traceback (most recent call last):
    File "<string>", line 1, in <module>

    File "C:\Users\runneradmin\AppData\Local\Temp\pip-install-4aa3kr17\ed25519_a0ba2e70de714928beb6110d8ba37a8a\setup.py", line 115, in <module>
      version=versioneer.get_version(),
              ^^^^^^^^^^^^^^^^^^^^^^^^

    File "C:\Users\runneradmin\AppData\Local\Temp\pip-install-4aa3kr17\ed25519_a0ba2e70de714928beb6110d8ba37a8a\versioneer.py", line 1405, in get_version
      return get_versions()["version"]
             ^^^^^^^^^^^^^^

    File "C:\Users\runneradmin\AppData\Local\Temp\pip-install-4aa3kr17\ed25519_a0ba2e70de714928beb6110d8ba37a8a\versioneer.py", line 1339, in get_versions
      cfg = get_config_from_root(root)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^

    File "C:\Users\runneradmin\AppData\Local\Temp\pip-install-4aa3kr17\ed25519_a0ba2e70de714928beb6110d8ba37a8a\versioneer.py", line 399, in get_config_from_root
      parser = configparser.SafeConfigParser()
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'?
  ----------------------------------------
WARNING: Discarding https://files.pythonhosted.org/packages/58/38/72ec85c953b90552fb015f31248256ef19e89a164a40ff8fef680259a608/ed25519-1.5.tar.gz#sha256=02053ee019ceef0df97294be2d4d5a8fc120fc86e81e08bec1245fc0f9403358 (from https://pypi.org/simple/ed25519/). Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

Closes #15 (I added all the versions that were missing from the pipeline up to 3.11-dev)

 - Switch from Travis to GitHub Actions
@davfsa davfsa mentioned this pull request Nov 21, 2021
2 tasks
- Update README to reflect changes
@davfsa
Copy link
Author

davfsa commented Dec 2, 2021

@warner Little bump on this :)

@davfsa
Copy link
Author

davfsa commented Jan 22, 2022

@warner Another bump :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant