-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3.11-dev support #847
Add 3.11-dev support #847
Conversation
Looks like yarl is not yet python 3.11 compatible, maybe worth opening an issue there Edit: Sorry, didnt see it was a draft |
Lol its fine, fun fact it automatically requested a review from you cause you're also a code owner of the stuff this is changing so I couldn't avoid that (well I might've been able to if I opened this as draft but it was opened as a normal PR to make sure that the actions actually run on it). |
And will do |
f8f5439
to
c50cdcc
Compare
c50cdcc
to
205e5c1
Compare
Waiting on warner/python-ed25519#16 |
We might have to setup a fork for python-ed25519, as it doesn't look like the PR is getting merged any time soon unfortunately |
|
e6b3b31
to
b66d511
Compare
For some context on the tests breaking, this is due to aiohttp and yarl not using the latest cython version, which fixes those bugs. We will have to wait for the next release then Relevant PRs: aio-libs/aiohttp#6396 and aio-libs/yarl#654 |
I'm aware, I'm just messing around with stuff to see if i can get it to run in the pipelines by just installing from source to see if anything does break cause i'm bored (but this has turned into too much effort so given up on the idea) |
3bf5fb7
to
13db1e8
Compare
Was just leaving it for prosperity and anybody that stumbles upon this :P |
13db1e8
to
4608b24
Compare
c913906
to
a8a4d3c
Compare
a8a4d3c
to
69a370d
Compare
Python 3.11.0b4 is now available, and Maybe it is irrelevant for this project idk |
We have been trying to test CPython 3.11 for some time now (reason for this pr), but the dependencies of hikari don't support 3.11 yet, so we can't yet as it fails to build |
32ffd9a
to
648cc8a
Compare
Aiohttp 3.8.3 just released and it has full support for Python 3.11. We can bump aiohttp to that minimum version and then (hopefully) this pr can be merged with python 3.11 support! |
Just re-triggering CI |
cchardet was dropped as a speedup for aiohttp (< python 3.10) in this version too due to it being unmaintained. There have been talks about a replacement, but no outcome yet. Best bet would be to just install The links for speedups should also have to be updated to just point to the aiohttp docs to see what packages are being installed on top |
Summary
Add 3.11 support
Checklist
nox
and all the pipelines have passed.Related issues