fix(ui): query panel suggestions displays the info of the next row due to an off-by-1 error #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=0adb5d3bf9b2b4a2c581e6198b02fb87db6a9e9b |
jamie-rasmussen
approved these changes
Oct 8, 2024
nicholaspun-wandb
force-pushed
the
nicholaspun-wb-18416
branch
4 times, most recently
from
8ffa28d to
895fe4c
Compare
nicholaspun-wandb
force-pushed
the
nicholaspun-wb-18416
branch
from
895fe4c to
f44633a
Compare
nicholaspun-wandb
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SuggestionRowso that we setsuggestionIndexproperly within the componentTesting
Tested via running FE locally.
Before:
After:
