Fix off-by-1 error in accessing suggestion indexes

wandb · Oct 18, 2024 · f44633a · f44633a
1 parent a8af605
commit f44633a
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/weave-js/src/panel/WeaveExpression/suggestions.tsx b/weave-js/src/panel/WeaveExpression/suggestions.tsx
@@ -81,13 +81,13 @@ export const Suggestions = (props: SuggestionProps) => {
           {Object.keys(items).map(suggestionCategory => (
             <React.Fragment key={suggestionCategory}>
               <S.SuggestionCategory>{suggestionCategory}</S.SuggestionCategory>
-              {items[suggestionCategory].map((s: any) => {
-                itemIndex++;
+              {items[suggestionCategory].map((suggestion: any) => {
+                const currentIndex = itemIndex++;
                 return (
                   <SuggestionRow
-                    key={itemIndex}
-                    idx={itemIndex}
-                    suggestion={s}
+                    key={currentIndex}
+                    idx={currentIndex}
+                    suggestion={suggestion}
                     takeSuggestion={takeSuggestion}
                     suggestionIndex={props.suggestionIndex}
                     setSuggestionIndex={props.setSuggestionIndex}