feat: object and op deletion backend + basic sdk + basic fe

tests/trace/test_weave_client.py

@@ -1544,3 +1544,147 @@ def func():
     calls = list(func.calls())
     call = calls[0]
     assert len(call.display_name) <= MAX_DISPLAY_NAME_LENGTH
+
+
+def test_object_deletion(client):
+    # Simple case, delete a single version of an object
+    obj = {"a": 5}
+    weave_obj = client.save(obj, "my-obj")
+    assert client.get(weave_obj.ref) == obj
+
+    client.delete_object_version(weave_obj.ref)
+    with pytest.raises(weave.trace_server.errors.ObjectDeletedError):
+        client.get(weave_obj.ref)
+
+    # create 3 versions of the object
+    obj["a"] = 6
+    weave_obj2 = client.save(obj, "my-obj")
+    obj["a"] = 7
+    weave_obj3 = client.save(obj, "my-obj")
+    obj["a"] = 8
+    weave_obj4 = client.save(obj, "my-obj")
+
+    # delete weave_obj3 with class method
+    weave_obj3.delete()
+
+    # make sure we can't get the deleted object
+    with pytest.raises(weave.trace_server.errors.ObjectDeletedError):
+        client.get(weave_obj3.ref)
+
+    # make sure we can still get the existing object versions
+    assert client.get(weave_obj4.ref)
+    assert client.get(weave_obj2.ref)
+
+    # count the number of versions of the object
+    versions = client.server.objs_query(
+        req=tsi.ObjQueryReq(
+            project_id=client._project_id(),
+            names=["my-obj"],
+            sort_by=[tsi.SortBy(field="created_at", direction="desc")],
+        )
+    )
+    assert len(versions.objs) == 2
+
+    # iterate over the versions, confirm the indexes are correct
+    assert versions.objs[0].version_index == 3
+    assert versions.objs[1].version_index == 1
+
+    weave_obj4.delete()
+    weave_obj2.delete()
+
+    versions = client.server.objs_query(
+        req=tsi.ObjQueryReq(
+            project_id=client._project_id(),
+            names=["my-obj"],
+        )
+    )
+    assert len(versions.objs) == 0
+
+
+def test_recursive_object_deletion(client):
+    # Create a bunch of objects that refer to each other
+    obj1 = {"a": 5}
+    obj1_ref = client.save(obj1, "obj1").ref
+
+    obj2 = {"b": obj1_ref}
+    obj2_ref = client.save(obj2, "obj2").ref
+
+    obj3 = {"c": obj2_ref}
+    obj3_ref = client.save(obj3, "obj3").ref
+
+    # Delete obj1
+    client.get(obj1_ref).delete()
+
+    # Make sure we can't get obj1
+    with pytest.raises(weave.trace_server.errors.ObjectDeletedError):
+        out = client.get(obj1_ref)
+        print(out)
+
+    # Make sure we can get obj2, but the ref to object 1 should return None
+    assert client.get(obj2_ref) == {"b": None}
+    # Object2 should store the ref to object2, as instantiated
+    assert client.get(obj3_ref) == {"c": obj2}
+
+
+def test_delete_all_versions(client):
+    obj = {"a": 5}
+    weave_obj = client.save(obj, "my-obj")
+    assert client.get(weave_obj.ref) == obj
+
+    client.delete_object_all_versions(weave_obj.ref)
+    with pytest.raises(weave.trace_server.errors.ObjectDeletedError):
+        client.get(weave_obj.ref)
+
+    # create 10 versions of the object
+    for i in range(10):
+        obj["a"] = i
+        weave_obj = client.save(obj, "my-obj-2")
+
+    client.delete_object_all_versions(weave_obj.ref)
+    objs = client.server.objs_query(
+        req=tsi.ObjQueryReq(
+            project_id=client._project_id(),
+            names=["my-obj-2"],
+        )
+    ).objs
+    assert len(objs) == 0
+
+
+@pytest.mark.skip("Deleting tables is not yet supported.")
+def test_table_object_deletion(client):
+    # create a dataset
+    data = [{"a": 1}, {"a": 2}, {"a": 3}]
+    dataset = weave.Table(data)
+    dataset_ref = client.save(dataset, "my-dataset").ref
+
+    # get the dataset
+    assert client.get(dataset_ref) == dataset
+
+    # delete the dataset
+    client.delete_object_version(dataset_ref)
+
+    # make sure we can't get the dataset
+    with pytest.raises(weave.trace_server.errors.ObjectDeletedError):
+        client.get(dataset_ref)
+
+    # recreate the EXACT SAME dataset
+    dataset = weave.Table(data)
+    dataset_ref = client.save(dataset, "my-dataset").ref
+
+    assert client.get(dataset_ref) == dataset
+    read_res = client.server.obj_read(
+        tsi.ObjReadReq(
+            project_id=client._project_id(),
+            object_id=dataset_ref.name,
+            digest=dataset_ref.digest,
+        )
+    )
+    # Version should be bumped
+    assert read_res.obj.version_index == 1
+
+    # delete the dataset again
+    client.delete_object_version(dataset_ref)
+
+    # make sure we can't get the dataset
+    with pytest.raises(weave.trace_server.errors.ObjectDeletedError):
+        client.get(dataset_ref)

weave-js/src/components/PagePanelComponents/Home/Browse2/SmallRef.tsx

@@ -125,6 +125,11 @@ export const SmallRef: FC<{
   }
   const objectVersion = useObjectVersion(objVersionKey);
   const opVersion = useOpVersion(opVersionKey);
+
+  const isDeleted =
+    isObjDeleteError(objectVersion?.error) ||
+    isObjDeleteError(opVersion?.error);
+
   const versionIndex =
     objectVersion.result?.versionIndex ?? opVersion.result?.versionIndex;
 
@@ -140,7 +145,6 @@ export const SmallRef: FC<{
     rootType = {type: 'OpDef'};
   }
   const {label} = objectRefDisplayName(objRef, versionIndex);
-
   const rootTypeName = getTypeName(rootType);
   let icon: IconName = IconNames.CubeContainer;
   if (rootTypeName === 'Dataset') {
@@ -177,13 +181,14 @@ export const SmallRef: FC<{
             overflow: 'hidden',
             whiteSpace: 'nowrap',
             textOverflow: 'ellipsis',
+            textDecoration: isDeleted ? 'line-through' : 'none',
           }}>
           {label}
         </Box>
       )}
     </Box>
   );
-  if (refTypeQuery.loading) {
+  if (refTypeQuery.loading || isDeleted) {
     return Item;
   }
   if (!isArtifactRef && !isWeaveObjRef) {
@@ -200,3 +205,12 @@ export const SmallRef: FC<{
     </Link>
   );
 };
+
+export const isObjDeleteError = (e: any): boolean => {
+  if (e == null) {
+    return false;
+  }
+  const errorStr = String(e);
+  const regex = /Obj .* was deleted at .*/;
+  return regex.test(errorStr);
+};

weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallPage/ObjectViewer.tsx

@@ -7,6 +7,7 @@ import {
   GridRowId,
 } from '@mui/x-data-grid-pro';
 import {Button} from '@wandb/weave/components/Button';
+import {parseRef} from '@wandb/weave/react';
 import _ from 'lodash';
 import React, {
   Dispatch,
@@ -21,6 +22,7 @@ import React, {
 import {parseRefMaybe} from '../../../../../../react';
 import {LoadingDots} from '../../../../../LoadingDots';
 import {Browse2OpDefCode} from '../../../Browse2/Browse2OpDefCode';
+import {objectRefDisplayName} from '../../../Browse2/SmallRef';
 import {isWeaveRef} from '../../filters/common';
 import {StyledDataGrid} from '../../StyledDataGrid';
 import {
@@ -161,10 +163,17 @@ export const ObjectViewer = ({
 
     const refValues: RefValues = {};
     for (const [r, v] of _.zip(refs, resolvedRefData)) {
-      if (!r || !v) {
+      if (!r) {
         // Shouldn't be possible
         continue;
       }
+      if (!v) {
+        // Value for ref not found, probably deleted
+        refValues[r] = {
+          _weave_is_deleted_ref: objectRefDisplayName(parseRef(r)).label,
+        };
+        continue;
+      }
       let val = r;
       if (v == null) {
         console.error('Error resolving ref', r);

weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallPage/ObjectViewerGroupingCell.tsx

@@ -32,7 +32,9 @@ export const ObjectViewerGroupingCell: FC<
     event.stopPropagation();
   };
 
+  const deletedRef = row.value?._weave_is_deleted_ref;
   const tooltipContent = row.path.toString();
+  const textContent = deletedRef ?? props.value;
   const box = (
     <CursorBox
       $isClickable={isGroup || isExpandableRef}
@@ -109,8 +111,9 @@ export const ObjectViewerGroupingCell: FC<
               textOverflow: 'ellipsis',
               whiteSpace: 'nowrap',
               flex: '1 1 auto',
+              textDecoration: deletedRef ? 'line-through' : 'none',
             }}>
-            {props.value}
+            {textContent}
           </Box>
         }
       />

weave-js/src/components/PagePanelComponents/Home/Browse3/pages/ObjectVersionPage.tsx

@@ -12,6 +12,7 @@ import {CustomWeaveTypeProjectContext} from '../typeViews/CustomWeaveTypeDispatc
 import {WeaveCHTableSourceRefContext} from './CallPage/DataTableView';
 import {ObjectViewerSection} from './CallPage/ObjectViewerSection';
 import {WFHighLevelCallFilter} from './CallsPage/callsTableFilter';
+import {DeleteObjectButtonWithModal} from './common/DeleteModal';
 import {
   CallLink,
   CallsLink,
@@ -94,7 +95,9 @@ export const ObjectVersionPage: React.FC<{
     path: props.filePath,
     refExtra: props.refExtra,
   });
-  if (objectVersion.loading) {
+  if (objectVersion.error) {
+    return <NotFoundPanel title={objectVersion.error.message} />;
+  } else if (objectVersion.loading) {
     return <CenteredAnimatedLoader />;
   } else if (objectVersion.result == null) {
     return <NotFoundPanel title="Object not found" />;
@@ -212,7 +215,7 @@ const ObjectVersionPageInner: React.FC<{
       }
       headerContent={
         <Tailwind>
-          <div className="grid w-full auto-cols-max grid-flow-col gap-[16px] text-[14px]">
+          <div className="grid w-full grid-flow-col grid-cols-[auto_auto_1fr_auto] gap-[16px] text-[14px]">
             <div className="block">
               <p className="text-moon-500">Name</p>
               <div className="flex items-center">
@@ -253,6 +256,9 @@ const ObjectVersionPageInner: React.FC<{
                 <p>{refExtra}</p>
               </div>
             )}
+            <div className="ml-auto">
+              <DeleteObjectButtonWithModal objVersionSchema={objectVersion} />
+            </div>
           </div>
         </Tailwind>
       }

weave-js/src/components/PagePanelComponents/Home/Browse3/pages/OpVersionPage.tsx

@@ -5,6 +5,7 @@ import {LoadingDots} from '../../../../LoadingDots';
 import {Tailwind} from '../../../../Tailwind';
 import {NotFoundPanel} from '../NotFoundPanel';
 import {OpCodeViewer} from '../OpCodeViewer';
+import {DeleteObjectButtonWithModal} from './common/DeleteModal';
 import {
   CallsLink,
   opNiceName,
@@ -76,7 +77,7 @@ const OpVersionPageInner: React.FC<{
       title={opVersionText(opId, versionIndex)}
       headerContent={
         <Tailwind>
-          <div className="grid w-full auto-cols-max grid-flow-col gap-[16px] text-[14px]">
+          <div className="grid w-full grid-flow-col grid-cols-[auto_auto_1fr_auto] gap-[16px] text-[14px]">
             <div className="block">
               <p className="text-moon-500">Name</p>
               <div className="flex items-center">
@@ -138,6 +139,9 @@ const OpVersionPageInner: React.FC<{
                 <p>-</p>
               )}
             </div>
+            <div className="block">
+              <DeleteObjectButtonWithModal objVersionSchema={opVersion} />
+            </div>
           </div>
         </Tailwind>
       }