-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: object and op deletion backend + basic sdk + basic fe #2319
base: master
Are you sure you want to change the base?
Conversation
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=f274a0c6431f3548244b2a9f1d6d07bf212cae96 |
const DialogContent = styled(MaterialDialogContent)` | ||
padding: 0 32px !important; | ||
`; | ||
DialogContent.displayName = 'S.DialogContent'; | ||
|
||
const DialogTitle = styled(MaterialDialogTitle)` | ||
padding: 32px 32px 16px 32px !important; | ||
|
||
h2 { | ||
font-weight: 600; | ||
font-size: 24px; | ||
line-height: 30px; | ||
} | ||
`; | ||
DialogTitle.displayName = 'S.DialogTitle'; | ||
|
||
const DialogActions = styled(MaterialDialogActions)<{$align: string}>` | ||
justify-content: ${({$align}) => | ||
$align === 'left' ? 'flex-start' : 'flex-end'} !important; | ||
padding: 32px 32px 32px 32px !important; | ||
`; | ||
DialogActions.displayName = 'S.DialogActions'; | ||
|
||
const DeleteModal: React.FC<{ | ||
object: ObjectVersionSchema; | ||
open: boolean; | ||
onClose: () => void; | ||
}> = ({object, open, onClose}) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: dry this with the call delete modal
if (!v) { | ||
// Value for ref not found, probably deleted | ||
refValues[r] = { | ||
_weave_is_deleted_ref: objectRefDisplayName(parseRef(r)).label, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is terrible, we need a better way of storing/rendering deleted refs in the object viewer.
Combo pr for testing / draft review
https://wandb.atlassian.net/browse/WB-20784
This pr:
obj_delete
api that can delete specific versions of an object, or all versions of the object.deleted_at
field. Before insert, we read from the db, and insert the full data payload, ensuring no data is lost.ReplacingMergeTree
deduplicates at merge, keeping the latest version of each row grouped by the primary (order by) key.deleted_at
set.TODO:
val_dump
here so its important to add a sane limit.val_dump
, and deletion occurs as an insertion.Api usage:
Depends on:
Deleted object in the call detail view:
Deleting in the calls table (refresh needs some work):