chore(weave): Legacy Refactor pt21

.github/workflows/cla.yaml

@@ -3,7 +3,7 @@ on:
   issue_comment:
     types: [created]
   pull_request_target:
-    types: [opened,closed,synchronize]
+    types: [opened, closed, synchronize]
 
 # explicitly configure permissions, in case your GITHUB_TOKEN workflow permissions are set to read-only in repository settings
 permissions:
@@ -22,9 +22,9 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
-          path-to-signatures: 'cla/signatures/version1/cla.json'
-          path-to-document: 'https://github.com/wandb/weave/blob/master/cla/cla.md' # e.g. a CLA or a DCO document
+          path-to-signatures: "cla/signatures/version1/cla.json"
+          path-to-document: "https://github.com/wandb/weave/blob/master/dev_docs/cla.md" # e.g. a CLA or a DCO document
           # branch should not be protected
-          branch: 'cla'
+          branch: "cla"
           # cannot use teams due to: https://github.com/contributor-assistant/github-action/issues/100
           allowlist: actions-user, altay, bdytx5, dannygoldstein, davidwallacejackson, jamie-rasmussen, jlzhao27, jo-fang, jwlee64, laxels, morganmcg1, nickpenaranda, scottire, shawnlewis, staceysv, tssweeney, vanpelt, vwrj, wandbmachine

.pre-commit-config.yaml

@@ -19,11 +19,6 @@ repos:
           [types-pkg-resources==0.1.3, types-all, wandb>=0.15.5]
         # You have to exclude in 3 places. 1) here. 2) mypi.ini exclude, 3) follow_imports = skip for each module in mypy.ini
         exclude: (.*pyi$)|(weave/legacy)|(weave/tests)
-  # Turn pyright back off, duplicative of mypy
-  # - repo: https://github.com/RobertCraigie/pyright-python
-  #   rev: v1.1.341
-  #   hooks:
-  #   - id: pyright
   - repo: local
     hooks:
       - id: jupyter-nb-clear-output

scripts/weave_server.sh

@@ -2,7 +2,7 @@
 
 # We could set WEAVE_BACKEND_HOST=http://localhost:9994/__weave but the frontend dev server
 # automatically forwards so it shouldn't be necessary.
-source ./config/auth_modes.sh
+source ./scripts/auth_modes.sh
 
 WEAVE_DISABLE_ANALYTICS=true
 WEAVE_SERVER_ENABLE_LOGGING=true

weave/legacy/scripts/jupyter_dev.sh

@@ -1,5 +1,3 @@
 #!/bin/sh
-(
-    source ./config/auth_modes.sh
-    WEAVE_FRONTEND_DEVMODE=true jupyter notebook
-)
+source ./scripts/auth_modes.sh
+WEAVE_FRONTEND_DEVMODE=true jupyter notebook

weave/legacy/weave/ref_base.py

@@ -17,7 +17,7 @@
 
 if typing.TYPE_CHECKING:
     from weave.legacy.weave import weave_types as types
-    from ..trace import weave_client
+    from ...trace import weave_client
 
 
 def _map_to_ref_strs(obj: typing.Any) -> typing.Any:

weave/trace/box.py

@@ -10,7 +10,7 @@
 
 import numpy as np
 
-from weave.legacy.weave.ref_base import Ref
+from weave.trace.refs import Ref
 
 T = TypeVar("T")
 

weave/trace/op_type.py

@@ -19,11 +19,11 @@
     get_class_source,
     is_running_interactively,
 )
+from weave.trace.op import Op
 from weave.trace.refs import ObjectRef
 
 from ..legacy.weave import environment
 from . import serializer
-from .op import Op
 
 WEAVE_OP_PATTERN = re.compile(r"@weave\.op(\(\))?")
 WEAVE_OP_NO_PAREN_PATTERN = re.compile(r"@weave\.op(?!\()")