Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(weave): Legacy Refactor pt21 #2239

Merged
merged 6 commits into from
Aug 28, 2024
Merged

chore(weave): Legacy Refactor pt21 #2239

merged 6 commits into from
Aug 28, 2024

Conversation

andrewtruong
Copy link
Collaborator

@andrewtruong andrewtruong commented Aug 27, 2024 •
edited
Loading

Split out from: #2182

This slice moves:

  • Docs to dev_docs (previously at root)
  • Remaining scripts to scripts
  • A test wrongly in trace to legacy

And cleans up:

  • A useless pyright config
  • Missing imports

@andrewtruong andrewtruong requested a review from a team as a code owner August 27, 2024 04:54
@andrewtruong
chore(weave): Legacy Refactor pt22 (#2240)
8ff732b 
* split: further split trace and legacy errors

* split: make separate trace and legacy utils

* delete: extraneous import
@andrewtruong andrewtruong merged commit f5c33e7 into andrew/ref20 Aug 28, 2024
14 of 15 checks passed
@andrewtruong andrewtruong deleted the andrew/ref21 branch August 28, 2024 19:12
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tssweeney tssweeney tssweeney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewtruong @tssweeney