chore: split node from CI #1566
Conversation
size-limit report 📦
|
|
Not sure why it appears 1 expected checks here. @weboko do you know? |
| DEBUG: ${{ (inputs.test_type == 'go-waku-master' || inputs.test_type == 'nwaku-master') && 'waku*' || '' }} | ||
|
|
||
| jobs: | ||
| node: |
There was a problem hiding this comment.
Github CI works in a way that if is sees a file in the workflows folder then it unfolds into steps in the CI.
One way can be to re-use the action but then you need to place it into actions folder (similar to actions/npm I created there) and from ther you can use it (I am not sure if it is possible to rely on it from different repo)
Or to create a file in workflows and expect it to be run in js-waku and nwaku and have conditions in it to handle that
There was a problem hiding this comment.
Tried to move it to actions but unfortunately it doesn't work. Actions is for jobs (like npm) not workflows and I need a workflow for the workflow_call functionality and cross repo usage.
So I need the new workflow to be excluded from the Required status checks in the Branch protection rules and made optional (similar to all other tests).
@weboko do you have access to do this or do I need to ask @fryorcraken ?
Thanks
There was a problem hiding this comment.
@weboko @fryorcraken little help here please
There was a problem hiding this comment.
@fbarbu15 was looking into it yesterday, to me it seemed that some different configuration might help here but if some setting on the repo required - I do not have access.
There was a problem hiding this comment.
Let me know if you have a better idea on how to handle this.
On the other hand to fix it on my implementation we need something like this(tried it on a forked repo):
There was a problem hiding this comment.
In that case we need to ask @fryorcraken to do the setting change
and I think we need to skip node Expected — Waiting for status to be reported in js-waku all together (seems it's already done)
fbarbu15
added
the
E:End-to-end testing
…re/split-ci-into-chunks
Problem
See #1548
Solution
Created a new workflow test-node that has the
workflow_calland can be called fromnwakuas wellRemoved
workflow_calland all extra conditions from the main workflowCalling the new workflow for all node test jobs