Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: split CI into separate chunks #1548

Closed
Tracked by #1453
weboko opened this issue Sep 8, 2023 · 3 comments
Closed
Tracked by #1453

chore: split CI into separate chunks #1548

weboko opened this issue Sep 8, 2023 · 3 comments
Assignees
@fbarbu15
Labels
E:End-to-end testing See https://github.com/waku-org/pm/issues/34 for details test Issue related to the test suite with no expected consequence to production code

Comments

@weboko
Copy link
Collaborator

weboko commented Sep 8, 2023

This is a change request

Problem

nwaku depends on some of our CI steps and the first solution was to use workflow_call. This is not ideal because now they have all of the steps from js-waku CI and not to run all of them we had to clutter code a bit with extra conditions.

Proposed Solutions

Split ci.yml into chunks so that they can be consumed or research other options (clone js-waku & inject nwaku through process.env e.g).

Notes

Original PR - #1541
@fryorcraken fryorcraken added this to Waku Sep 8, 2023
@weboko weboko moved this to Triage in Waku Sep 8, 2023
@weboko
Copy link
Collaborator Author

weboko commented Sep 8, 2023

cc @fbarbu15 @vpavlin

This was referenced Sep 8, 2023
Closed
Merged
@fbarbu15 fbarbu15 mentioned this issue Sep 12, 2023
Merged
@fbarbu15
Copy link
Collaborator

Added this PR for the splitting of the CI: #1566

@fbarbu15
Copy link
Collaborator

Applied changes to a forked nwaku repo: https://github.com/nwaku-test-org/nwaku/actions/runs/6170532712
PR: nwaku-test-org/nwaku#18

@weboko weboko moved this from Triage to In Progress in Waku Sep 14, 2023
@weboko weboko assigned weboko and fbarbu15 and unassigned weboko Sep 14, 2023
@fryorcraken fryorcraken added test Issue related to the test suite with no expected consequence to production code E:End-to-end testing See https://github.com/waku-org/pm/issues/34 for details and removed test Issue related to the test suite with no expected consequence to production code labels Sep 19, 2023
This was referenced Sep 21, 2023
Closed
Merged
@fryorcraken fryorcraken added the test Issue related to the test suite with no expected consequence to production code label Sep 21, 2023
@fbarbu15 fbarbu15 moved this from In Progress to Done in Waku Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbarbu15 fbarbu15

Labels
E:End-to-end testing See https://github.com/waku-org/pm/issues/34 for details test Issue related to the test suite with no expected consequence to production code
Projects
Waku
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fbarbu15 @fryorcraken @weboko