chore: added workflow_call to the ci.yml #1541
Conversation
size-limit report 📦
|
| @@ -13,6 +13,11 @@ on: | |||
| description: "Docker hub image name taken from https://hub.docker.com/r/statusteam/nim-waku/tags. Format: statusteam/nim-waku:v0.19.0" | |||
| required: false | |||
| type: string | |||
| workflow_call: | |||
There was a problem hiding this comment.
Is is accesible now from nwaku? I am not sure the organizational setting allows it now
There was a problem hiding this comment.
@vpavlin is doing the changes on nwaku side and we'll check if we can use reusable workflows across repos. Worst case we need to use github api
There was a problem hiding this comment.
Looks like I am able to execute this from my workflows (even outside of waku-org) - https://github.com/nwaku-test-org/nwaku/actions/runs/6110682343/job/16584422746
Looks pretty awesome!
There was a problem hiding this comment.
even outside of
waku-org
huh, we need to fix it, I guess the setting is too generous
@fryorcraken can you limit execution only to the same org?
There was a problem hiding this comment.
Why? It's a public repo, which is IMO how this gets "pulled in" to your workflow execution - the actual execution happens on caller runners, so it does not really influence you/the js-waku repo
There was a problem hiding this comment.
I agree that splitting this WF up into smaller chunks would make sense, but would it be ok to merge it as is and the iterate over it? I'd like to get this in on our side before our release next week (i.e. ideally merge both PRs today)
There was a problem hiding this comment.
Considering that we need to run just node and node-optional tests, and exclude any other jobs, then indeed using reusable workflows for those steps would be the best approach.
In that case the nwaku CI will call the node.yml and node-optional.yml instead of calling the whole ci.yml
Would that work for you @vpavlin ?
There was a problem hiding this comment.
I'm ok to merge it and create a new PR with the splitting. @weboko what about you?
And if you are ok, can you please merge it? Because I don't have merge access. Thanks
There was a problem hiding this comment.
oh, I thought you could merge yourself
I agree with follow-up to this later, let's track it here #1548
There was a problem hiding this comment.
Works great!
see example execution from my test-org:
https://github.com/nwaku-test-org/nwaku/actions/runs/6110682343/job/16584422746
fbarbu15
added
the
E:End-to-end testing
Problem
When nwaku creates a release it needs to run the jswaku tests (ideally automatically) against the release
Solution
Added workflow_call so the ci can be invoked via reusable workflows
Exclude based on the caller input the un-needed jobs
Notes