-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add option to specify preferred peers for filter and use bad peer removal logic only for lightpush and filter #1244
base: master
Are you sure you want to change the base?
Conversation
Jenkins BuildsClick to see older builds (9)
|
be7eb68
to
5322d34
Compare
c6c6479
to
6bdf125
Compare
484e141
to
9cdf9ec
Compare
9cdf9ec
to
213d382
Compare
aadfbd6
to
26bbb69
Compare
26bbb69
to
313c6bf
Compare
params.peersToExclude = make(peermanager.PeerSet) | ||
} | ||
//exclude peers that are preferredpeers so that they don't get selected again. | ||
if _, ok := params.peersToExclude[p]; !ok { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe selectedPeers
are the peers that we want to request, put selectedPeers
further in another param doesn't make sense to me, and the naming peersToExclude
further confuses me.
You probably want an internal state (not from params) like peersAlreadySelected
to help selecting the peers?
Description
Bunch of fixes and changes that help with offline state.
Changes
Tests
Being dogfooded status-im/status-mobile#21172 for various network disconnection/switch scenarios.