fix_: bad peer check logic for lightmode and some fixes #5964
+362
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (62)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5964 +/- ##
===========================================
- Coverage 60.88% 60.80% -0.08%
===========================================
Files 811 811
Lines 108894 108894
===========================================
- Hits 66303 66218 -85
- Misses 34841 34893 +52
- Partials 7750 7783 +33
Flags with carried forward coverage won't be shown. Click here to find out more. |
chaitanyaprem
force-pushed
the
test/filter-bad-peers
branch
3 times, most recently
from
1ff9e98
to
9576201
Compare
chaitanyaprem
force-pushed
the
test/filter-bad-peers
branch
from
9576201
to
eb75669
Compare
chaitanyaprem
force-pushed
the
test/filter-bad-peers
branch
from
eb75669
to
801db12
Compare
chaitanyaprem
force-pushed
the
test/filter-bad-peers
branch
3 times, most recently
from
c04fe5f
to
18469e9
Compare
chaitanyaprem
requested review from
richard-ramos,
kaichaosun and
igor-sirotin
and removed request for
richard-ramos
chaitanyaprem
changed the title
richard-ramos
approved these changes
Nov 29, 2024
chaitanyaprem
force-pushed
the
test/filter-bad-peers
branch
from
18469e9
to
a4a54ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple bad peer removal logic for lightclients based on dial failures.
Additional fixes as per waku-org/go-waku#1244
May help improve scenarios such as status-im/status-mobile#21172