Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits Auction Schedule #5250

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Edits Auction Schedule #5250

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad26254
added Jonas feedback
filippoweb3 Oct 4, 2023
5b495a0
added Jonas feedback
filippoweb3 Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/Auction-Schedule.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,14 +138,14 @@ function Render(explorerUrl, auctions, setAuctions, index) {
Block #{auctions[index].startBlock.height}
</a>
<hr />
<b>Bidding Starts:</b>
<b>Ending Period Starts:</b>
<br />
{`${biddingStartsDate} - `}
<a href={`${explorerUrl}${auctions[index].biddingStartBlock.height}`}>
Block #{auctions[index].biddingStartBlock.height}
</a>
<hr />
<b>Bidding Ends:</b>
<b>Auction Ends:</b>
<br />
{`${biddingEndsDate} - `}
<a href={`${explorerUrl}${auctions[index].biddingEndsBlock.height}`}>
Expand Down
2 changes: 1 addition & 1 deletion docs/learn/learn-auction.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ auction on Kusama. Keep in mind that the candle phase has a uniform termination
equal probability of ending at any given block, and the termination block cannot be predicted before
or during the auction.

- Auction 9 starts at
- The ending period of auction 9 starts at
[`block 9362014`](https://kusama.subscan.io/extrinsic/0x7b67d653c9522b623a97e20a967b83a8517fe3821370475ddb6611cd37c29a03?event=9335014-26).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link actually points to the auctionStarted event. So, indeed, the original intention was wrong. It does not make sense to point to it now. We could either point to the whole overview of the auction or to the winningOffset of that auction.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks!


:::note The auction has a full duration equal to `block 9362014` + `72000`
Expand Down
Loading