Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits Auction Schedule #5250

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Edits Auction Schedule #5250

merged 2 commits into from
Oct 5, 2023

Conversation

filippoweb3
Copy link
Contributor

No description provided.

@filippoweb3 filippoweb3 self-assigned this Oct 4, 2023
@filippoweb3 filippoweb3 linked an issue Oct 4, 2023 that may be closed by this pull request
@filippoweb3 filippoweb3 added the A2 - Please Review Pull request is ready for review. label Oct 4, 2023
@filippoweb3 filippoweb3 requested review from DrW3RK and jonasW3F October 4, 2023 12:38
@@ -96,7 +96,7 @@ auction on Kusama. Keep in mind that the candle phase has a uniform termination
equal probability of ending at any given block, and the termination block cannot be predicted before
or during the auction.

- Auction 9 starts at
- The ending period of auction 9 starts at
[`block 9362014`](https://kusama.subscan.io/extrinsic/0x7b67d653c9522b623a97e20a967b83a8517fe3821370475ddb6611cd37c29a03?event=9335014-26).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link actually points to the auctionStarted event. So, indeed, the original intention was wrong. It does not make sense to point to it now. We could either point to the whole overview of the auction or to the winningOffset of that auction.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks!

@DrW3RK DrW3RK merged commit ca567e9 into master Oct 5, 2023
3 checks passed
@DrW3RK DrW3RK deleted the edit-auction-schedule branch October 5, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Clarify Auction Section
3 participants