Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor logging #71

Merged
merged 10 commits into from
Jan 19, 2023
Merged

Refactor logging #71

merged 10 commits into from
Jan 19, 2023

Conversation

agalitsyn
Copy link
Contributor

@agalitsyn agalitsyn commented Jan 17, 2023 •
edited by asdek
Loading

after #70

linked with #46

  • use global logger, pass it to gin and gorm for following the format and log level
  • drop file loggers, rotation should be handled by docker logging driver, not app

@agalitsyn agalitsyn self-assigned this Jan 18, 2023
@agalitsyn agalitsyn added the enhancement New feature or request label Jan 18, 2023
@agalitsyn agalitsyn linked an issue Jan 18, 2023 that may be closed by this pull request
Refactor logging #53
Closed
2 tasks
@agalitsyn agalitsyn added this to the Technical release milestone Jan 18, 2023
NexoMichael
NexoMichael approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@NexoMichael NexoMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agalitsyn agalitsyn mentioned this pull request Jan 19, 2023
Merged
@asdek asdek merged commit d182a6c into master Jan 19, 2023
@asdek asdek deleted the refactor-logging branch January 19, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NexoMichael NexoMichael NexoMichael approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
SOLDR
Status: ✅ Done
Milestone
Technical release
Development

Successfully merging this pull request may close these issues.

Refactor logging
3 participants
@agalitsyn @NexoMichael @asdek