Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor config #72

Merged
merged 6 commits into from
Jan 26, 2023
Merged

Refactor config #72

merged 6 commits into from
Jan 26, 2023

Conversation

agalitsyn
Copy link
Contributor

@agalitsyn agalitsyn commented Jan 19, 2023

after #71

linked with #46

Use config lib for parsing whole configuration on app start and remove os.GetEnv and similar functions from modules

@agalitsyn agalitsyn added the enhancement New feature or request label Jan 19, 2023
@agalitsyn agalitsyn added this to the Technical release milestone Jan 19, 2023
@agalitsyn agalitsyn self-assigned this Jan 19, 2023
Copy link
Collaborator

@NexoMichael NexoMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@asdek asdek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agalitsyn agalitsyn merged commit 38b606e into master Jan 26, 2023
@agalitsyn agalitsyn deleted the refactor-config branch January 26, 2023 05:21
@asdek asdek restored the refactor-config branch January 26, 2023 10:40
@asdek asdek deleted the refactor-config branch January 26, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants