fix slicingwithrange cop

voxpupuli · Feb 20, 2024 · d7fa73d · d7fa73d
1 parent 083e280
commit d7fa73d
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 15 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -58,13 +58,3 @@ Style/ClassEqualityComparison:
   Exclude:
     - 'lib/puppet/provider/cs_primitive/crm.rb'
     - 'lib/puppet/provider/cs_primitive/pcs.rb'
-
-# Offense count: 5
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/SlicingWithRange:
-  Exclude:
-    - 'lib/puppet/type/cs_clone.rb'
-    - 'lib/puppet/type/cs_colocation.rb'
-    - 'lib/puppet/type/cs_group.rb'
-    - 'lib/puppet/type/cs_location.rb'
-    - 'lib/puppet/type/cs_order.rb'
diff --git a/lib/puppet/type/cs_clone.rb b/lib/puppet/type/cs_clone.rb
@@ -110,7 +110,7 @@
 
   def unmunge_cs_primitive(name)
     name = name.split(':')[0]
-    name = name[3..-1] if name.start_with? 'ms_'
+    name = name[3..] if name.start_with? 'ms_'
 
     name
   end

diff --git a/lib/puppet/type/cs_colocation.rb b/lib/puppet/type/cs_colocation.rb
@@ -106,7 +106,7 @@ def extract_primitives
 
   def unmunge_cs_primitive(name)
     name = name.split(':')[0]
-    name = name[3..-1] if name.start_with? 'ms_'
+    name = name[3..] if name.start_with? 'ms_'
 
     name
   end

diff --git a/lib/puppet/type/cs_group.rb b/lib/puppet/type/cs_group.rb
@@ -65,7 +65,7 @@ def insync?(is)
 
   def unmunge_cs_primitive(name)
     name = name.split(':')[0]
-    name = name[3..-1] if name.start_with? 'ms_'
+    name = name[3..] if name.start_with? 'ms_'
 
     name
   end

diff --git a/lib/puppet/type/cs_location.rb b/lib/puppet/type/cs_location.rb
@@ -108,7 +108,7 @@ def insync?(is)
 
   def unmunge_cs_primitive(name)
     name = name.split(':')[0]
-    name = name[3..-1] if name.start_with? 'ms_'
+    name = name[3..] if name.start_with? 'ms_'
 
     name
   end

diff --git a/lib/puppet/type/cs_order.rb b/lib/puppet/type/cs_order.rb
@@ -113,7 +113,7 @@ def unmunge_cs_resourcename(name)
     return if name.nil?
 
     name = name.split(':')[0]
-    name = name[3..-1] if name.start_with? 'ms_'
+    name = name[3..] if name.start_with? 'ms_'
 
     name
   end