fix safenavigation cop

voxpupuli · Feb 20, 2024 · 083e280 · 083e280
1 parent 8aea42c
commit 083e280
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -59,14 +59,6 @@ Style/ClassEqualityComparison:
     - 'lib/puppet/provider/cs_primitive/crm.rb'
     - 'lib/puppet/provider/cs_primitive/pcs.rb'
 
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength.
-# AllowedMethods: present?, blank?, presence, try, try!
-Style/SafeNavigation:
-  Exclude:
-    - 'lib/puppet/provider/cs_primitive/pcs.rb'
-
 # Offense count: 5
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Style/SlicingWithRange:

diff --git a/lib/puppet/provider/cs_primitive/pcs.rb b/lib/puppet/provider/cs_primitive/pcs.rb
@@ -269,7 +269,7 @@ def flush
     if @resource && @resource.class.name == :cs_primitive && @resource[:unmanaged_metadata]
       @resource[:unmanaged_metadata].each do |parameter_name|
         @property_hash[:metadata].delete(parameter_name)
-        @property_hash[:existing_metadata].delete(parameter_name) if @property_hash[:existing_metadata]
+        @property_hash[:existing_metadata]&.delete(parameter_name)
       end
     end