Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Set v1a2 as the storageVersion #246

Merged
merged 1 commit into from
Oct 12, 2023
Merged

✨ Set v1a2 as the storageVersion #246

merged 1 commit into from
Oct 12, 2023

Conversation

bryanv
Copy link
Contributor

@bryanv bryanv commented Oct 12, 2023 •
edited
Loading

This is effectively a noop when the v1a2 FFS is not enabled since our post install configure script already forces the storageVersion back to v1a1 in that case. But when the FFS is enabled this results in the correct storageVersion being set.

NONE

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Oct 12, 2023
@bryanv
Set v1a2 as the storageVersion
bd35dbb 
This is effectively a noop when the v1a2 FFS is not enabled since our
post install configure script already forces the storageVersion back to
v1a1 in that case. But when the FFS is enabled this results in the
correct storageVersion being set.
@bryanv bryanv force-pushed the bryanv/set-v1a2-storageversion branch from f9c8a8d to bd35dbb Compare October 12, 2023 21:12
@github-actions
Copy link

Code Coverage

Package Line Rate Health
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/v1alpha1/clustercontentlibraryitem 83% ✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/v1alpha1/contentlibraryitem 82% ✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/v1alpha1/contentsource 87% ✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/v1alpha1/utils 95% ✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/v1alpha2/clustercontentlibraryitem 86% ✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/v1alpha2/contentlibraryitem 85% ✔
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/v1alpha2/utils 91% ✔
github.com/vmware-tanzu/vm-operator/controllers/infracluster 75% ➖
github.com/vmware-tanzu/vm-operator/controllers/infraprovider 75% ➖
github.com/vmware-tanzu/vm-operator/controllers/providerconfigmap 75% ➖
github.com/vmware-tanzu/vm-operator/controllers/util/encoding 73% ➖
github.com/vmware-tanzu/vm-operator/controllers/util/remote 41% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/v1alpha1 45% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/v1alpha2 69% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineclass/v1alpha1 31% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineclass/v1alpha2 71% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinepublishrequest/v1alpha1 83% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinepublishrequest/v1alpha2 81% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha1 81% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha1/providers 96% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha1/providers/simplelb 66% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha1/utils 84% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha2 82% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha2/providers 96% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha2/providers/simplelb 66% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/v1alpha2/utils 83% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinesetresourcepolicy/v1alpha1 80% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinesetresourcepolicy/v1alpha2 80% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1 74% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha2 72% ➖
github.com/vmware-tanzu/vm-operator/controllers/volume/v1alpha1 87% ✔
github.com/vmware-tanzu/vm-operator/controllers/volume/v1alpha2 87% ✔
github.com/vmware-tanzu/vm-operator/pkg/builder 71% ➖
github.com/vmware-tanzu/vm-operator/pkg/conditions 90% ✔
github.com/vmware-tanzu/vm-operator/pkg/conditions2 90% ✔
github.com/vmware-tanzu/vm-operator/pkg/context 0% ❌
github.com/vmware-tanzu/vm-operator/pkg/context/fake 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/lib 84% ✔
github.com/vmware-tanzu/vm-operator/pkg/manager 78% ➖
github.com/vmware-tanzu/vm-operator/pkg/metrics 90% ✔
github.com/vmware-tanzu/vm-operator/pkg/metrics2 85% ✔
github.com/vmware-tanzu/vm-operator/pkg/patch 79% ➖
github.com/vmware-tanzu/vm-operator/pkg/patch2 78% ➖
github.com/vmware-tanzu/vm-operator/pkg/prober 92% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/context 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/fake 85% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/fake/probe 83% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/fake/worker 88% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/probe 83% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/worker 86% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober2 94% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober2/context 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober2/fake 85% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober2/fake/probe 83% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober2/fake/worker 89% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober2/probe 89% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober2/worker 85% ✔
github.com/vmware-tanzu/vm-operator/pkg/record 89% ✔
github.com/vmware-tanzu/vm-operator/pkg/topology 85% ✔
github.com/vmware-tanzu/vm-operator/pkg/util 83% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube 89% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/vm 74% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/fake 76% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere 71% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/client 74% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/clustermodules 85% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/config 85% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/contentlibrary 71% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/credentials 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/instancestorage 92% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/internal 0% ❌
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/network 88% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/placement 83% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/resources 53% ❌
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/session 84% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/storage 77% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/test 98% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/vcenter 80% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere/virtualmachine 84% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2 71% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/client 49% ❌
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/clustermodules 85% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/config 70% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/contentlibrary 50% ❌
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/credentials 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/instancestorage 75% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/internal 0% ❌
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/network 79% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/placement 70% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/resources 38% ❌
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/session 85% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/storage 77% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/test 98% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/vcenter 80% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/virtualmachine 87% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmprovider/providers/vsphere2/vmlifecycle 75% ➖
github.com/vmware-tanzu/vm-operator/pkg/webconsolevalidation 53% ❌
github.com/vmware-tanzu/vm-operator/webhooks/common 100% ✔
github.com/vmware-tanzu/vm-operator/webhooks/persistentvolumeclaim/validation 95% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/v1alpha1/mutation 81% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/v1alpha1/validation 94% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/v1alpha2/mutation 83% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/v1alpha2/validation 88% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/v1alpha1/mutation 59% ❌
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/v1alpha1/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/v1alpha2/mutation 59% ❌
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/v1alpha2/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinepublishrequest/v1alpha1/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinepublishrequest/v1alpha2/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/v1alpha1/mutation 62% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/v1alpha1/validation 91% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/v1alpha2/mutation 62% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/v1alpha2/validation 91% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesetresourcepolicy/v1alpha1/mutation 62% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesetresourcepolicy/v1alpha1/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesetresourcepolicy/v1alpha2/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha1/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha2/validation 92% ✔
Summary 79% (11412 / 14421) ➖

Minimum allowed line rate is 60%

@bryanv bryanv merged commit 408aa67 into vmware-tanzu:main Oct 12, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akutz akutz akutz approved these changes

Assignees
No one assigned
Labels
cla-not-required size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryanv @akutz @vmwclabot