Skip to content

Commit

Permalink
Set v1a2 as the storageVersion
Browse files Browse the repository at this point in the history
This is effectively a noop with the v1a2 FFS is not enabled since our
post install configure script already forces the storageVersion back to
v1a1 in that case. But when the FFS is enabled this results in the
correct storageVersion being set.
  • Loading branch information
bryanv committed Oct 12, 2023
1 parent 77d0ce9 commit f9c8a8d
Show file tree
Hide file tree
Showing 19 changed files with 28 additions and 28 deletions.
2 changes: 1 addition & 1 deletion api/v1alpha1/virtualmachine_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ func (vm *VirtualMachine) SetConditions(conditions Conditions) {

// +kubebuilder:object:root=true
// +kubebuilder:resource:scope=Namespaced,shortName=vm
// +kubebuilder:storageversion
// +kubebuilder:storageversion:false
// +kubebuilder:subresource:status
// +kubebuilder:printcolumn:name="Power-State",type="string",JSONPath=".status.powerState"
// +kubebuilder:printcolumn:name="Class",type="string",priority=1,JSONPath=".spec.className"
Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha1/virtualmachineclass_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ type VirtualMachineClassStatus struct {

// +kubebuilder:object:root=true
// +kubebuilder:resource:scope=Cluster,shortName=vmclass
// +kubebuilder:storageversion
// +kubebuilder:storageversion:false
// +kubebuilder:subresource:status
// +kubebuilder:printcolumn:name="CPU",type="string",JSONPath=".spec.hardware.cpus"
// +kubebuilder:printcolumn:name="Memory",type="string",JSONPath=".spec.hardware.memory"
Expand Down
4 changes: 2 additions & 2 deletions api/v1alpha1/virtualmachineimage_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ func (vmImage *VirtualMachineImage) SetConditions(conditions Conditions) {

// +kubebuilder:object:root=true
// +kubebuilder:resource:scope=Cluster,shortName=vmi;vmimage
// +kubebuilder:storageversion
// +kubebuilder:storageversion:false
// +kubebuilder:subresource:status
// +kubebuilder:printcolumn:name="Image-Name",type="string",JSONPath=".status.imageName"
// +kubebuilder:printcolumn:name="Version",type="string",JSONPath=".spec.productInfo.version"
Expand Down Expand Up @@ -194,7 +194,7 @@ func (clusterVirtualMachineImage *ClusterVirtualMachineImage) SetConditions(cond

// +kubebuilder:object:root=true
// +kubebuilder:resource:scope=Cluster,shortName=cvmi;cvmimage;clustervmi;clustervmimage
// +kubebuilder:storageversion
// +kubebuilder:storageversion:false
// +kubebuilder:subresource:status
// +kubebuilder:printcolumn:name="Image-Name",type="string",JSONPath=".status.imageName"
// +kubebuilder:printcolumn:name="Version",type="string",JSONPath=".spec.productInfo.version"
Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha1/virtualmachinepublishrequest_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ func (vmpr *VirtualMachinePublishRequest) SetConditions(conditions Conditions) {

// +kubebuilder:object:root=true
// +kubebuilder:resource:scope=Namespaced,shortName=vmpub
// +kubebuilder:storageversion
// +kubebuilder:storageversion:false
// +kubebuilder:subresource:status

// VirtualMachinePublishRequest defines the information necessary to publish a
Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha1/virtualmachineservice_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ type VirtualMachineServiceStatus struct {

// +kubebuilder:object:root=true
// +kubebuilder:resource:shortName=vmservice
// +kubebuilder:storageversion
// +kubebuilder:storageversion:false
// +kubebuilder:subresource:status
// +kubebuilder:printcolumn:name="Type",type="string",JSONPath=".spec.type"
// +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp"
Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha1/virtualmachinesetresourcepolicy_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ type ClusterModuleStatus struct {
}

// +kubebuilder:object:root=true
// +kubebuilder:storageversion
// +kubebuilder:storageversion:false
// +kubebuilder:subresource:status

// VirtualMachineSetResourcePolicy is the Schema for the virtualmachinesetresourcepolicies API.
Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha2/virtualmachine_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ type VirtualMachineStatus struct {

// +kubebuilder:object:root=true
// +kubebuilder:resource:scope=Namespaced,shortName=vm
// +kubebuilder:storageversion:false
// +kubebuilder:storageversion
// +kubebuilder:subresource:status
// +kubebuilder:printcolumn:name="Class",type="string",priority=1,JSONPath=".status.class.name"
// +kubebuilder:printcolumn:name="Image",type="string",priority=1,JSONPath=".status.image.name"
Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha2/virtualmachineclass_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ type VirtualMachineClassStatus struct {

// +kubebuilder:object:root=true
// +kubebuilder:resource:scope=Cluster,shortName=vmclass
// +kubebuilder:storageversion:false
// +kubebuilder:storageversion
// +kubebuilder:subresource:status
// +kubebuilder:printcolumn:name="CPU",type="string",JSONPath=".spec.hardware.cpus"
// +kubebuilder:printcolumn:name="Memory",type="string",JSONPath=".spec.hardware.memory"
Expand Down
4 changes: 2 additions & 2 deletions api/v1alpha2/virtualmachineimage_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ type VirtualMachineImageStatus struct {

// +kubebuilder:object:root=true
// +kubebuilder:resource:scope=Cluster,shortName=vmi;vmimage
// +kubebuilder:storageversion:false
// +kubebuilder:storageversion
// +kubebuilder:subresource:status
// +kubebuilder:printcolumn:name="Image Name",type="string",JSONPath=".status.name"
// +kubebuilder:printcolumn:name="Image Version",type="string",JSONPath=".status.productInfo.version"
Expand Down Expand Up @@ -246,7 +246,7 @@ type VirtualMachineImageList struct {

// +kubebuilder:object:root=true
// +kubebuilder:resource:scope=Cluster,shortName=cvmi;cvmimage;clustervmi;clustervmimage
// +kubebuilder:storageversion:false
// +kubebuilder:storageversion
// +kubebuilder:subresource:status
// +kubebuilder:printcolumn:name="Image Name",type="string",JSONPath=".status.name"
// +kubebuilder:printcolumn:name="Image Version",type="string",JSONPath=".status.productInfo.version"
Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha2/virtualmachinepublishrequest_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ type VirtualMachinePublishRequestStatus struct {

// +kubebuilder:object:root=true
// +kubebuilder:resource:scope=Namespaced,shortName=vmpub
// +kubebuilder:storageversion:false
// +kubebuilder:storageversion
// +kubebuilder:subresource:status

// VirtualMachinePublishRequest defines the information necessary to publish a
Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha2/virtualmachineservice_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ type VirtualMachineServiceStatus struct {

// +kubebuilder:object:root=true
// +kubebuilder:resource:shortName=vmservice
// +kubebuilder:storageversion:false
// +kubebuilder:storageversion
// +kubebuilder:subresource:status
// +kubebuilder:printcolumn:name="Type",type="string",JSONPath=".spec.type"
// +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp"
Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha2/virtualmachinesetresourcepolicy_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ type VSphereClusterModuleStatus struct {
}

// +kubebuilder:object:root=true
// +kubebuilder:storageversion:false
// +kubebuilder:storageversion
// +kubebuilder:subresource:status

// VirtualMachineSetResourcePolicy is the Schema for the virtualmachinesetresourcepolicies API.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ spec:
type: object
type: object
served: true
storage: true
storage: false
subresources:
status: {}
- additionalPrinterColumns:
Expand Down Expand Up @@ -513,6 +513,6 @@ spec:
type: object
type: object
served: true
storage: false
storage: true
subresources:
status: {}
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ spec:
type: object
type: object
served: true
storage: true
storage: false
subresources:
status: {}
- additionalPrinterColumns:
Expand Down Expand Up @@ -499,6 +499,6 @@ spec:
type: object
type: object
served: true
storage: false
storage: true
subresources:
status: {}
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ spec:
type: object
type: object
served: true
storage: true
storage: false
subresources:
status: {}
- additionalPrinterColumns:
Expand Down Expand Up @@ -516,6 +516,6 @@ spec:
type: object
type: object
served: true
storage: false
storage: true
subresources:
status: {}
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ spec:
type: object
type: object
served: true
storage: true
storage: false
subresources:
status: {}
- name: v1alpha2
Expand Down Expand Up @@ -595,6 +595,6 @@ spec:
type: object
type: object
served: true
storage: false
storage: true
subresources:
status: {}
4 changes: 2 additions & 2 deletions config/crd/bases/vmoperator.vmware.com_virtualmachines.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,7 @@ spec:
type: object
type: object
served: true
storage: true
storage: false
subresources:
status: {}
- additionalPrinterColumns:
Expand Down Expand Up @@ -2709,6 +2709,6 @@ spec:
type: object
type: object
served: true
storage: false
storage: true
subresources:
status: {}
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ spec:
type: object
type: object
served: true
storage: true
storage: false
subresources:
status: {}
- additionalPrinterColumns:
Expand Down Expand Up @@ -323,6 +323,6 @@ spec:
type: object
type: object
served: true
storage: false
storage: true
subresources:
status: {}
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ spec:
type: object
type: object
served: true
storage: true
storage: false
subresources:
status: {}
- name: v1alpha2
Expand Down Expand Up @@ -222,6 +222,6 @@ spec:
type: object
type: object
served: true
storage: false
storage: true
subresources:
status: {}

0 comments on commit f9c8a8d

Please sign in to comment.