Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Bumps & Use golang 1.22/1.23 in CI & Fix linter issues #221

Merged
merged 6 commits into from
Jan 4, 2025

Conversation

anujc25
Copy link
Contributor

@anujc25 anujc25 commented Jan 2, 2025

What this PR does / why we need it

- Bump CI to start using golang v1.22 and 1.23 to run the CI for builds and unit tests

  • 1.18 and 1.19 are already out of support for sometime now. (I was facing some weird issues with the compatibility tests when using older version after the dependency bump and hence the bump

- Fix linter issues because we started using 1.23 and latest linter.

- Dependency Updates:

  • golang.org/x/net from v0.21.0 to v0.33.0
  • google.golang.org/protobuf from v1.28.1 to v1.33.0
  • github.com/vektah/gqlparser/v2 from v2.5.11 to v2.5.14
  • golang.org/x/tools from v0.18.0 to v0.24.0 (tried to bump to latest v0.28.0 but it requires minimum golang version to v1.22. if needed that change should be done as part of separate change)

Which issue(s) this PR fixes

Fixes

Describe testing done for PR

Release note

None

Additional information

Special notes for your reviewer

@anujc25 anujc25 requested a review from a team as a code owner January 2, 2025 23:19
@anujc25 anujc25 force-pushed the anujc/dependency-updates-jan-02 branch 3 times, most recently from 98f8e25 to 49e70e8 Compare January 2, 2025 23:48
@anujc25 anujc25 marked this pull request as draft January 2, 2025 23:53
@anujc25 anujc25 force-pushed the anujc/dependency-updates-jan-02 branch from d896d06 to 3bc1d85 Compare January 3, 2025 12:35
- golang.org/x/net from v0.21.0 to v0.33.0
- google.golang.org/protobuf from v1.28.1 to v1.33.0
- github.com/vektah/gqlparser/v2 from v2.5.11 to v2.5.14
- golang.org/x/tools from v0.18.0 to v0.24.0

Signed-off-by: Anuj Chaudhari <[email protected]>
@anujc25 anujc25 force-pushed the anujc/dependency-updates-jan-02 branch from 3bc1d85 to 2e46c9b Compare January 3, 2025 12:44
@anujc25 anujc25 force-pushed the anujc/dependency-updates-jan-02 branch from 6a24909 to 1081bc1 Compare January 3, 2025 13:08
@anujc25 anujc25 force-pushed the anujc/dependency-updates-jan-02 branch 5 times, most recently from b7840b1 to bb9708b Compare January 3, 2025 17:19
@anujc25 anujc25 force-pushed the anujc/dependency-updates-jan-02 branch from bb9708b to 371aeb1 Compare January 3, 2025 17:41
@anujc25 anujc25 marked this pull request as ready for review January 3, 2025 17:51
@anujc25 anujc25 changed the title Dependency Bumps Dependency Bumps & Use golang 1.22/1.23 in CI & Fix linter issues Jan 3, 2025
Copy link
Contributor

@prkalle prkalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the changes and fixing the linter issues.

@anujc25 anujc25 merged commit 3e9bbba into vmware-tanzu:main Jan 4, 2025
4 checks passed
@anujc25 anujc25 deleted the anujc/dependency-updates-jan-02 branch January 4, 2025 22:57
anujc25 added a commit to anujc25/tanzu-plugin-runtime that referenced this pull request Jan 6, 2025
…ware-tanzu#221)

* Dependency Bumps and remove go.work, go.work.sum files

- golang.org/x/net from v0.21.0 to v0.33.0
- google.golang.org/protobuf from v1.28.1 to v1.33.0
- github.com/vektah/gqlparser/v2 from v2.5.11 to v2.5.14
- golang.org/x/tools from v0.18.0 to v0.24.0

* Update CI to use golang 1.22 and 1.23
- Fix linter errors flagged with latest golanglint

Signed-off-by: Anuj Chaudhari <[email protected]>
anujc25 added a commit that referenced this pull request Jan 6, 2025
…) (#222)

* Dependency Bumps and remove go.work, go.work.sum files

- golang.org/x/net from v0.21.0 to v0.33.0
- google.golang.org/protobuf from v1.28.1 to v1.33.0
- github.com/vektah/gqlparser/v2 from v2.5.11 to v2.5.14
- golang.org/x/tools from v0.18.0 to v0.24.0

* Update CI to use golang 1.22 and 1.23
- Fix linter errors flagged with latest golanglint

Signed-off-by: Anuj Chaudhari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants