Fix linter errors flagged with latest golanglint

Signed-off-by: Anuj Chaudhari <[email protected]>

.golangci.yaml

@@ -104,6 +104,7 @@ issues:
     - 'declaration of "(err|ctx)" shadows declaration at'
     - 'unnamedResult: consider giving a name to these results'
     - '(Expect directory permissions to be 0750 or less|Expect (WriteFile|file) permissions to be 0600 or less)'
+    - 'dot-imports: should not use dot imports'
 
   exclude-rules:
     - path: _test\.go
@@ -164,4 +165,4 @@ run:
 # golangci.com configuration
 # https://github.com/golangci/golangci/wiki/Configuration
 service:
-  golangci-lint-version: 1.46.0 # use the fixed version to not introduce new linters unexpectedly
+  golangci-lint-version: 1.63.3 # use the fixed version to not introduce new linters unexpectedly

command/deprecate_test.go

@@ -9,8 +9,8 @@ import (
 
 	"github.com/spf13/cobra"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // Using dot import for readability in test files
+	. "github.com/onsi/gomega"    //nolint:revive // Using dot import for readability in test files
 )
 
 func TestCommand(t *testing.T) {

component/output.go

@@ -196,7 +196,7 @@ func (obw *objectwriter) SetKeys(_ ...string) {
 }
 
 // MarkDynamicKeys marks the headers as dynamic
-func (obw *objectwriter) MarkDynamicKeys(dynamicKeys ...string) {
+func (obw *objectwriter) MarkDynamicKeys(_ ...string) {
 	// Object writer does not have the concept of dynamic keys
 	fmt.Fprintln(obw.out, "Programming error, attempt to mark dynamic headers to object output")
 }

component/reader_test.go

@@ -7,8 +7,8 @@ import (
 	"os"
 	"testing"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // Using dot import for readability in test files
+	. "github.com/onsi/gomega"    //nolint:revive // Using dot import for readability in test files
 )
 
 func TestComponent(t *testing.T) {

config/contexts_test.go

@@ -7,7 +7,7 @@ import (
 	"fmt"
 	"testing"
 
-	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // Using dot import for readability in test files
 	"github.com/onsi/gomega"
 
 	"github.com/stretchr/testify/assert"

log/logger.go

@@ -46,7 +46,7 @@ func getLogThreshold() int32 {
 	if reqLogLevelStr != "" {
 		requestedLogLevel, err := strconv.ParseUint(reqLogLevelStr, 10, 32)
 		if err == nil {
-			return int32(requestedLogLevel)
+			return int32(requestedLogLevel) //nolint:gosec // overflow conversion does not apply
 		}
 		fmt.Fprintf(os.Stderr, "invalid value %q for %s\n", reqLogLevelStr, EnvTanzuCLILogLevel)
 	}
@@ -145,7 +145,7 @@ func (l *logger) Outputf(format string, args ...interface{}) {
 // V returns an InfoLogger value for a specific verbosity level.
 func (l *logger) V(level int) LoggerImpl {
 	nl := l.clone()
-	nl.level = int32(level)
+	nl.level = int32(level) //nolint:gosec // overflow conversion does not apply
 	return nl
 }
 
@@ -184,7 +184,7 @@ func (l *logger) Clone() LoggerImpl {
 func (l *logger) CloneWithLevel(level int) LoggerImpl {
 	return &logger{
 		threshold:  l.threshold,
-		level:      int32(level),
+		level:      int32(level), //nolint:gosec // overflow conversion does not apply
 		prefix:     l.prefix,
 		values:     copySlice(l.values),
 		callDepth:  l.callDepth,

test/compatibility/testplugins/runtime-test-plugin-latest/cmd/test.go

@@ -18,7 +18,7 @@ var (
 	testCmd  = &cobra.Command{
 		Use:   "test",
 		Short: "A test command that parse the file and trigger the runtime apis",
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			// Parse the file into array of apis struct
 			apis, err := compatibilitytestingcore.ParseRuntimeAPIsFromFile(filepath)
 			if err != nil {

test/compatibility/testplugins/runtime-test-plugin-v0_11_6/cmd/test.go

@@ -19,7 +19,7 @@ var (
 	testCmd  = &cobra.Command{
 		Use:   "test",
 		Short: "A test command that parse the apis file and trigger the runtime library apis",
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			apis, err := core.ParseRuntimeAPIsFromFile(filepath)
 			if err != nil {
 				fmt.Println(err)

test/compatibility/testplugins/runtime-test-plugin-v0_25_4/cmd/test.go

@@ -18,7 +18,7 @@ var (
 	testCmd  = &cobra.Command{
 		Use:   "test",
 		Short: "A test command that parse the file and trigger the runtime apis",
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			apis, err := core.ParseRuntimeAPIsFromFile(filepath)
 			if err != nil {
 				fmt.Println(err)

test/compatibility/testplugins/runtime-test-plugin-v0_28_0/cmd/test.go

@@ -18,7 +18,7 @@ var (
 	testCmd  = &cobra.Command{
 		Use:   "test",
 		Short: "A test command that parse the file and trigger the runtime apis",
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			// Parse the file into array of apis struct
 			apis, err := core.ParseRuntimeAPIsFromFile(filepath)
 			if err != nil {

test/compatibility/testplugins/runtime-test-plugin-v0_90/cmd/test.go

@@ -18,7 +18,7 @@ var (
 	testCmd  = &cobra.Command{
 		Use:   "test",
 		Short: "A test command that parse the file and trigger the runtime apis",
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			// Parse the file into array of apis struct
 			apis, err := compatibilitytestingcore.ParseRuntimeAPIsFromFile(filepath)
 			if err != nil {

test/compatibility/testplugins/runtime-test-plugin-v1_0_2/cmd/test.go

@@ -18,7 +18,7 @@ var (
 	testCmd  = &cobra.Command{
 		Use:   "test",
 		Short: "A test command that parse the file and trigger the runtime apis",
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			// Parse the file into array of apis struct
 			apis, err := compatibilitytestingcore.ParseRuntimeAPIsFromFile(filepath)
 			if err != nil {

test/plugin_e2e_test.go

@@ -10,8 +10,8 @@ import (
 	"path/filepath"
 	"testing"
 
-	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
+	. "github.com/onsi/ginkgo/v2" //nolint:revive // Using dot import for readability in test files
+	. "github.com/onsi/gomega"    //nolint:revive // Using dot import for readability in test files
 
 	executil "github.com/vmware-tanzu/tanzu-plugin-runtime/test/exec"
 )