Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added security_policy_id to resource definition #37

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Added security_policy_id to resource definition #37

wants to merge 10 commits into from

Conversation

vmanilo
Copy link
Owner

@vmanilo vmanilo commented Nov 10, 2023 •
edited
Loading

Resolves

Changes

  • added security_policy_id

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6900109084

  • 89 of 117 (76.07%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 90.411%
Changes Missing Coverage Covered Lines Changed/Added Lines %
twingate/internal/test/acctests/helper.go 19 31 61.29%
twingate/internal/provider/resource/resource.go 42 58 72.41%
Files with Coverage Reduction New Missed Lines %
twingate/internal/provider/resource/resource.go 2 89.86%
Totals Coverage Status
Change from base Build 6809082196: -0.3%
Covered Lines: 5261
Relevant Lines: 5819
💛 - Coveralls

@vmanilo vmanilo mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmanilo @coveralls @romankor