Feature: added security_policy_id to resource definition

[vmanilo]

Resolves #380

Tests passes: https://github.com/vmanilo/terraform-provider-twingate/actions/runs/6900109331/job/18772776593?pr=37

Changes

• added optional security_policy_id attribute to Resource definition

[twingate-blee]

My resource was set to "Default Policy". I then used security_policy_id to set it to a different security policy lets call it "Test Policy". I then removed security_policy_id and ran Terraform which set the the value to null

security_policy_id = "U2VjdXJpdHlQb2xpY3k6Njk4MjA=" -> null

I was thinking that my resources would go back to "Default Policy" but it stayed on "Test Policy"

For me to get back to default state I had to security_policy_id to the "Default Policy" then run terraform then I was able to delete security_policy_id.

We might want to explain that removing security_policy_id will still use the current policy and not go back to the previous policy.

[romankor]

see comments

[vmanilo]

@twingate-blee this behaviour was not specified in spec, that's why it was missing
but now I've updated implementation

[twingate-blee]

My resource was set to "Default Policy". I then used security_policy_id to set it to a different security policy lets call it "Test Policy". I then removed security_policy_id and ran Terraform which set the the value to null

security_policy_id = "U2VjdXJpdHlQb2xpY3k6Njk4MjA=" -> null

I was thinking that my resources would go back to "Default Policy" but it stayed on "Test Policy"

For me to get back to default state I had to security_policy_id to the "Default Policy" then run terraform then I was able to delete security_policy_id.

We might want to explain that removing security_policy_id will still use the current policy and not go back to the previous policy.

I retested after your update and verified that if you remove security_policy_id it defaults to "Default Policy". I also tested setting the security policy to another policy from the UI. Ran terraform without security_policy_id and verified that it didn't try to change it to "Default Policy"

[vmanilo]

I see, working on it

[vmanilo]

hey @twingate-blee I've pushed a commit to address your comment
please give it a try

[romankor]

GTM