Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DigitalOcean Deployment #368

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Add DigitalOcean Deployment #368

merged 5 commits into from
Oct 15, 2024

Conversation

dkarnutsch
Copy link
Contributor

@dkarnutsch dkarnutsch commented Sep 23, 2024

Description

Add deployment based on DigitalOcean's app platform. The apps are split per domain to be compatible with routing from the app platform.

The preview does not work yet, as I'm waiting for vivid-planet/comet#2554.

I decided to not commit the symlinks and copy the files instead to keep the required changes minimal.

The secrets are safe inside the repo as they are encrypted.

This does not include a secondary site, but could be added later.

Screenshots/screencasts

Related tasks and documents

Open TODOs/questions (Future PR)

  • Remove dependency to dkarnutsch/oauth2-proxy (no really trustworthy image from Docker Hub found and GitHub registry does not work yet on DigitalOcean)
  • Replace domains with starter.comet-dxp.com and admin.starter.comet-dxp.com
  • Add CI/CD based on GitHub Actions

Further information

@johnnyomair
Copy link
Collaborator

I decided to not commit the symlinks and copy the files instead to keep the required changes minimal.

Should we still add them in a separate PR?

.digitalocean/comet-starter-cms.yaml Outdated Show resolved Hide resolved
.digitalocean/comet-starter-cms.yaml Outdated Show resolved Hide resolved
.digitalocean/comet-starter-imgproxy.yaml Outdated Show resolved Hide resolved
.digitalocean/comet-starter-site.yaml Outdated Show resolved Hide resolved
@dkarnutsch
Copy link
Contributor Author

I decided to not commit the symlinks and copy the files instead to keep the required changes minimal.

Should we still add them in a separate PR?

I'm not sure. It would simplify the install.sh, but we need it anyway, so I'm not sure if it has real benefits. One small benefit would be that the files are available when browsing through GitHub or GitLab.

@dkarnutsch dkarnutsch force-pushed the digitalocean-deployment branch 2 times, most recently from 4ae799b to 288893e Compare October 7, 2024 07:13
@dkarnutsch dkarnutsch force-pushed the digitalocean-deployment branch from 288893e to 8c43afc Compare October 7, 2024 07:15
@dkarnutsch
Copy link
Contributor Author

@johnnyomair @nsams @fraxachun @thomasdax98 this PR is now ready. For the preview to work I'll wait until vivid-planet/comet#2554 is released.

@fraxachun
Copy link
Contributor

The imgproxy is not deployed automatically or is just that I can't identify the code which invokes .digitalocean/comet-starter-imgproxy.yaml?

@dkarnutsch
Copy link
Contributor Author

The imgproxy is not deployed automatically or is just that I can't identify the code which invokes .digitalocean/comet-starter-imgproxy.yaml?

Yes, you are right. I've added it to deploy.sh with 9e7c137

fraxachun
fraxachun previously approved these changes Oct 8, 2024
.digitalocean/deploy.sh Outdated Show resolved Hide resolved
.digitalocean/comet-starter-cms.tpl.yaml Show resolved Hide resolved
@dkarnutsch
Copy link
Contributor Author

@nsams Do you want to review this as well?

@johnnyomair johnnyomair removed the request for review from nsams October 15, 2024 13:01
@dkarnutsch dkarnutsch merged commit c07ee74 into main Oct 15, 2024
3 checks passed
@dkarnutsch dkarnutsch deleted the digitalocean-deployment branch October 15, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants