Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Digitalocean #324

Closed
wants to merge 19 commits into from
Closed

Digitalocean #324

wants to merge 19 commits into from

Conversation

dkarnutsch
Copy link
Contributor

@dkarnutsch dkarnutsch commented Aug 6, 2024 •
edited
Loading

  • Buildpacks should install dev dependencies as well
  • site/comet-config.json does not work if symlink (at runtime, buildtime is fine)

PR Checklist

  • Link to the respective task if one exists:
  • Provide screenshots/screencasts if the change contains visual changes
Screenshots/screencasts

@dkarnutsch dkarnutsch self-assigned this Aug 6, 2024
johnnyomair
johnnyomair reviewed Aug 7, 2024
View reviewed changes
api/src/db/ormconfig.ts Outdated Show resolved Hide resolved
admin/block-meta.json Outdated Show resolved Hide resolved
admin/package.json Outdated Show resolved Hide resolved
@dkarnutsch dkarnutsch mentioned this pull request Sep 17, 2024
Merged
2 tasks
johnnyomair pushed a commit that referenced this pull request Sep 23, 2024
@dkarnutsch
API: Use config for ORM config (#365)
8a5c19c 
Use config instead of directly accessing env vars for additional type
safety and validation.

Feedback from
#324 (comment)
@dkarnutsch dkarnutsch closed this Sep 23, 2024
@dkarnutsch dkarnutsch deleted the digitalocean branch September 23, 2024 14:25
@dkarnutsch
Copy link
Contributor Author

Continued in #368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyomair johnnyomair johnnyomair left review comments

Assignees

@dkarnutsch dkarnutsch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkarnutsch @johnnyomair