Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Beanshell Sleep(0) (and equivalent Audit or Alert calls) should only refresh the screen. #13707

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

riverwanderer
Copy link
Collaborator

@riverwanderer riverwanderer commented Nov 20, 2024

This PR bypasses Thread.sleep() in DialogCloser.java for intervals less than 1 ms.

Previously an interval of zero was passed, for no apparent gain (a sleep interval is relatively unpredictable at short durations).
Also, a negative interval was overridden as 500ms. This change treats a negative value the same as zero.

@riverwanderer riverwanderer added the Awaiting Testing/Feedback Change is good, but neeeds testing or feedback label Nov 20, 2024
@riverwanderer riverwanderer added this to the 3.7.16 milestone Nov 20, 2024
@riverwanderer riverwanderer self-assigned this Nov 20, 2024
Implements sleep bypass (screen dialog close only) for intervals of zero or less.
@riverwanderer riverwanderer added Build Only - Do not merge and removed Awaiting Testing/Feedback Change is good, but neeeds testing or feedback labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant