Improvement to BeanShell Sleep() #13710
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rors (parameters).
riverwanderer
added
enhancement
|
This PR (as build VASSAL-3.8.0-SNAPSHOT-6fb758e-master-zeroSleep ) has tested OK on MacOS & Windows in a full game using CCN module v5.1.0beta9, which makes extensive use of Sleep(0). In this test no adverse effects were noted and the other user perceived improved performance. |
riverwanderer
added
Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A further change building on #13707 makes BeanShell Sleep() less obtrusive by disabling the OS decoration on Sleep's JDialog box.
This PR also corrects some minor doc errors in parameter headings.