Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly adjust Player window title to reflect actions taken in Welcome Wizard #12780

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Correctly adjust Player window title to reflect actions taken in Welcome Wizard #12780

merged 1 commit into from
Oct 8, 2023

Conversation

riverwanderer
Copy link
Collaborator

No description provided.

@riverwanderer riverwanderer added the bug Something isn't working label Oct 2, 2023
@riverwanderer riverwanderer added this to the 3.7.2 milestone Oct 2, 2023
@riverwanderer riverwanderer self-assigned this Oct 2, 2023
@riverwanderer riverwanderer linked an issue Oct 2, 2023 that may be closed by this pull request
Wizard fails to update Pre-defined scenario file name in window title nor resets same on cancellation of a normal game load #12755
Closed
@riverwanderer
Copy link
Collaborator Author

Tests out ok. Fixes a couple of Wizard / Window title anomalies without introducing new features.

@riverwanderer riverwanderer added the Ready for Review Ready to be reviewed for Merging label Oct 2, 2023
BrentEaston
BrentEaston approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@BrentEaston BrentEaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me

@BrentEaston BrentEaston added Ready to Merge YeeeeeeeeeeeHAW!!! and removed Ready for Review Ready to be reviewed for Merging labels Oct 4, 2023
@uckelman uckelman changed the title Fixes for Wizard actions on window title. Correctly adjust Player window title to reflect actions taken in Welcome Wizard Oct 8, 2023
@uckelman uckelman merged commit 14435a4 into vassalengine:master Oct 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrentEaston BrentEaston BrentEaston approved these changes

Assignees

@riverwanderer riverwanderer

Labels
bug Something isn't working Ready to Merge YeeeeeeeeeeeHAW!!!
Projects
None yet
Milestone
3.7.2
3 participants
@riverwanderer @BrentEaston @uckelman