Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wizard fails to update Pre-defined scenario file name in window title nor resets same on cancellation of a normal game load #12755

Closed
riverwanderer opened this issue Sep 27, 2023 · 0 comments · Fixed by #12763 or #12780
Closed

Wizard fails to update Pre-defined scenario file name in window title nor resets same on cancellation of a normal game load #12755

riverwanderer opened this issue Sep 27, 2023 · 0 comments · Fixed by #12763 or #12780
Assignees
@riverwanderer
Labels
bug Something isn't working
Milestone
3.7.2

Comments

@riverwanderer
Copy link
Collaborator

riverwanderer commented Sep 27, 2023 •
edited
Loading

Pre-defined scenario file name is updated in window title by wizard. In other circumstances, external game file or PDS opened from within the module, the window titles are updated.

This impacts proposed PR #12753 to make game file name available via a property.

Also, opening a file and then backing up to disable/exit the wizard does not reset the game file in the title window.
@riverwanderer riverwanderer added the bug Something isn't working label Sep 27, 2023
@riverwanderer riverwanderer added this to the 3.7.2 milestone Sep 27, 2023
@riverwanderer riverwanderer self-assigned this Sep 27, 2023
@riverwanderer riverwanderer linked a pull request Sep 27, 2023 that will close this issue
Last file name property #12753
Closed
@riverwanderer riverwanderer mentioned this issue Sep 28, 2023
Closed
@riverwanderer riverwanderer linked a pull request Sep 29, 2023 that will close this issue
Added VassalGameFileName property #12763
Merged
@riverwanderer riverwanderer changed the title Pre-defined scenario file name is not logged to chat by wizard. Wizard fails to update Pre-defined scenario file name in window title nor resets same on cancellation of a normal game load Oct 2, 2023
@riverwanderer riverwanderer linked a pull request Oct 2, 2023 that will close this issue
Correctly adjust Player window title to reflect actions taken in Welcome Wizard #12780
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riverwanderer riverwanderer

Labels
bug Something isn't working
Projects
None yet
Milestone
3.7.2
1 participant
@riverwanderer